Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jackson-databind and jackson-annotations dependencies now coming from core #652

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Dec 29, 2022

Signed-off-by: Sicheng Song [email protected]

Description

jackson-databind and jackson-annotations were added as api dependencies in server of opensearch core. The security plugin now gets these dependencies transitively and does not need direct dependencies on the jars.

PR in core where the dependencies are added: opensearch-project/OpenSearch#5366

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Maintenance

Issues Resolved

This PR will resolve #634

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@b4sjoo b4sjoo requested a review from a team December 29, 2022 00:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #652 (4c73713) into 2.x (a82359e) will decrease coverage by 0.73%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #652      +/-   ##
============================================
- Coverage     84.91%   84.18%   -0.74%     
+ Complexity      986      972      -14     
============================================
  Files            92       92              
  Lines          3540     3540              
  Branches        326      326              
============================================
- Hits           3006     2980      -26     
- Misses          399      424      +25     
- Partials        135      136       +1     
Flag Coverage Δ
ml-commons 84.18% <ø> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/opensearch/ml/cluster/DiscoveryNodeHelper.java 89.39% <0.00%> (-9.10%) ⬇️
...ain/java/org/opensearch/ml/task/MLTaskManager.java 60.20% <0.00%> (-6.81%) ⬇️
...n/java/org/opensearch/ml/cluster/MLSyncUpCron.java 87.50% <0.00%> (-6.25%) ⬇️
.../ml/action/syncup/TransportSyncUpOnNodeAction.java 87.87% <0.00%> (-6.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo merged commit 26435de into opensearch-project:2.x Dec 29, 2022
@b4sjoo b4sjoo deleted the 2.x_dev branch December 30, 2022 21:59
ryanbogan added a commit to ryanbogan/ml-commons that referenced this pull request Jan 10, 2023
ryanbogan added a commit to ryanbogan/ml-commons that referenced this pull request Jan 10, 2023
…now coming from core (opensearch-project#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan added a commit to ryanbogan/ml-commons that referenced this pull request Jan 10, 2023
…now coming from core (opensearch-project#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <[email protected]>
b4sjoo pushed a commit that referenced this pull request Jan 10, 2023
…now coming from core (#652)" (#684)

* disable prebuilt model (#682)

* disable prebuilt model

Signed-off-by: Yaliang Wu <[email protected]>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>

* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
…now coming from core (#652)" (#684)

* disable prebuilt model (#682)

* disable prebuilt model

Signed-off-by: Yaliang Wu <[email protected]>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>

* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
(cherry picked from commit d169568)
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Feb 17, 2023
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Feb 17, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684)

* disable prebuilt model (opensearch-project#682)

* disable prebuilt model

Signed-off-by: Yaliang Wu <[email protected]>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>

* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 2, 2023
ylwu-amzn pushed a commit that referenced this pull request Mar 2, 2023
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 2, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684)

* disable prebuilt model (opensearch-project#682)

* disable prebuilt model

Signed-off-by: Yaliang Wu <[email protected]>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>

* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn added a commit that referenced this pull request Mar 2, 2023
…now coming from core (#652)" (#684) (#774)

* disable prebuilt model (#682)

* disable prebuilt model



* add volatile for trusted url regex






* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)"

This reverts commit 26435de.

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Co-authored-by: Ryan Bogan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants