Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jackson-databind and jackson-annotations dependencies now coming from core #651

Closed
wants to merge 1 commit into from

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Dec 28, 2022

Signed-off-by: Sicheng Song [email protected]

Description

jackson-databind and jackson-annotations were added as api dependencies in server of opensearch core. The security plugin now gets these dependencies transitively and does not need direct dependencies on the jars.

PR in core where the dependencies are added: opensearch-project/OpenSearch#5366

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Maintenance

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@b4sjoo b4sjoo requested a review from a team December 28, 2022 23:55
@codecov-commenter
Copy link

Codecov Report

Merging #651 (2ddea3f) into 2.x (ec8a997) will increase coverage by 4.19%.
The diff coverage is 47.61%.

@@             Coverage Diff              @@
##                2.x     #651      +/-   ##
============================================
+ Coverage     79.86%   84.06%   +4.19%     
- Complexity      927      970      +43     
============================================
  Files            92       92              
  Lines          3522     3540      +18     
  Branches        324      326       +2     
============================================
+ Hits           2813     2976     +163     
+ Misses          586      427     -159     
- Partials        123      137      +14     
Flag Coverage Δ
ml-commons 84.06% <47.61%> (+4.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...h/ml/action/unload/TransportUnloadModelAction.java 79.68% <47.61%> (+62.29%) ⬆️
...ain/java/org/opensearch/ml/task/MLTaskManager.java 60.20% <0.00%> (ø)
...arch/ml/action/forward/TransportForwardAction.java 90.90% <0.00%> (+9.09%) ⬆️
.../ml/action/syncup/TransportSyncUpOnNodeAction.java 87.87% <0.00%> (+69.69%) ⬆️
...ml/action/load/TransportLoadModelOnNodeAction.java 94.44% <0.00%> (+75.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo closed this Dec 29, 2022
@b4sjoo b4sjoo deleted the 2.x_repair branch December 29, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants