-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update create page flow according to design #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 18, 2024
karrui
changed the title
feat: show layout screen and create default blob according to layout
feat: update create page flow according to design
Jul 18, 2024
seaerchin
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! please fix the as
cast - using as const satisfies
+ removing the type provided works as expected.
some things i felt were done v well in this PR:
- doing the nitty gritty business logic stuff in the context and exposing wrappers to callers of the hook
- keeping each individual component "simple" code-wise (
groupHover
is pog) and exporting helper components to do 1 thing well (XMotionBox
) - i think we might be reusing the transformation logic (replacing non-alphanum to
-
and only whenisDirty
) - i feel that there's value in moving it out to a custom hook but i'm ok to do it later also. leave it to you ba
...tudio/src/features/editing-experience/components/CreatePageModal/CreatePageWizardContext.tsx
Show resolved
Hide resolved
...tudio/src/features/editing-experience/components/CreatePageModal/CreatePageWizardContext.tsx
Show resolved
Hide resolved
...tudio/src/features/editing-experience/components/CreatePageModal/CreatePageWizardContext.tsx
Outdated
Show resolved
Hide resolved
...tudio/src/features/editing-experience/components/CreatePageModal/CreatePageWizardContext.tsx
Outdated
Show resolved
Hide resolved
karrui
force-pushed
the
move_some_page_metadata_into_resource
branch
from
July 19, 2024 05:49
a73dd07
to
3de6f11
Compare
karrui
force-pushed
the
update_create_flow_to_also_select_layout
branch
from
July 19, 2024 05:49
5ac7bad
to
dc389ea
Compare
karrui
force-pushed
the
move_some_page_metadata_into_resource
branch
from
July 19, 2024 07:55
4e5718b
to
f0a0ee6
Compare
design say don't want :(
this should be extracted out into a single PR
karrui
force-pushed
the
update_create_flow_to_also_select_layout
branch
from
July 19, 2024 08:01
ab6ceb7
to
8fc2856
Compare
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR introduces a new
CreatePageModal
component and updates the page creation flow. Deprecated modal components have been removed, and the new modal includes form validation, expected behavior, and animation effects for better UI/UX.What changed?
CreatePageModal
component that allows users to create new pages with options for layout, title, and URL.PageCreateModal
,LayoutSelection
, etc.Motionbox
.How to test?
Why make this change?
The existing page creation components were outdated and did not offer a smooth user experience. This new implementation provides a more intuitive interface with necessary validations and enhanced visuals, making it easier for users to create new pages.
tldr of this is that design changed