Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create initial dashboard page #308

Merged
merged 8 commits into from
Jul 19, 2024
Merged

feat: create initial dashboard page #308

merged 8 commits into from
Jul 19, 2024

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Jul 11, 2024 •
edited
Loading

TL;DR

This PR adds a new /dashboard page to go to a specific site

What changed?

  1. Site Listing:
    • Introduced a new SiteList component that lists all sites a user has access to.
    • Added new database query in site.router.ts to fetch site list.
  2. Report Issue Button:
    • Added a button in the AppNavbar to allow users to report issues via the Isomer issue tracker.
  3. Component Updates:
    • Updated AppNavbar to include new functionality and style tweaks.
    • Changed the logo source in AppNavbar.tsx.
    • Updated dashboard.tsx with new site listing component.
    • Refactored various storybook files to include new handlers and remove unnecessary layouts.

How to test?

New stories

@vercel Vercel
Copy link

vercel bot commented Jul 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ❌ Failed (Inspect) Jul 19, 2024 7:10am

@karrui karrui mentioned this pull request Jul 11, 2024
Merged
@karrui Graphite App
Copy link
Contributor Author

karrui commented Jul 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karrui and the rest of your teammates on Graphite Graphite

@karrui karrui mentioned this pull request Jul 11, 2024
Merged
@karrui Graphite App
Copy link
Contributor Author

karrui commented Jul 11, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karrui and the rest of your teammates on Graphite Graphite

@karrui karrui changed the title feat: update app navbar to look more like design feat: create initial dashboard page Jul 11, 2024
@karrui karrui mentioned this pull request Jul 11, 2024
Merged
@karrui karrui marked this pull request as ready for review July 11, 2024 16:58
@karrui karrui requested a review from a team as a code owner July 11, 2024 16:58
@karrui karrui force-pushed the create_initial_dashboard_page branch from 34a36ca to 188c1bf Compare July 15, 2024 05:07
This was referenced Jul 15, 2024
Merged
Merged
Merged
Merged
seaerchin
seaerchin reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@seaerchin seaerchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, things that i thought was interesting was the use of Suspense here

apps/studio/public/assets/isomer-logo.svg Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why black colour

apps/studio/src/features/dashboard/SiteList.tsx
)
}

export const SiteList = withSuspense(SuspendableSiteList, <SiteListSkeleton />)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

@karrui karrui force-pushed the use_chromatic_for_viewport_instead_of_stories branch from 0a0cbaf to b866ab1 Compare July 17, 2024 02:44
@karrui karrui force-pushed the create_initial_dashboard_page branch from 49dacd6 to 5ceb313 Compare July 17, 2024 02:44
@karrui karrui mentioned this pull request Jul 18, 2024
Merged
@karrui Graphite App
Copy link
Contributor Author

karrui commented Jul 19, 2024 •
edited
Loading

Merge activity

@karrui karrui force-pushed the use_chromatic_for_viewport_instead_of_stories branch from b866ab1 to 7aaf303 Compare July 19, 2024 05:48
@karrui karrui force-pushed the create_initial_dashboard_page branch from 5ceb313 to 3bbcc58 Compare July 19, 2024 05:48
Base automatically changed from use_chromatic_for_viewport_instead_of_stories to main July 19, 2024 07:08
@karrui karrui force-pushed the create_initial_dashboard_page branch from 3bbcc58 to 0c90215 Compare July 19, 2024 07:08
@karrui karrui merged commit 8ce3def into main Jul 19, 2024
13 of 16 checks passed
@karrui karrui deleted the create_initial_dashboard_page branch July 19, 2024 07:13
This was referenced Jul 19, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin left review comments

@dcshzj dcshzj dcshzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrui @dcshzj @seaerchin