feat: add types to JSON columns in prisma schema #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 16, 2024
karrui
changed the title
type prefix from isomer-components
seaerchin
approved these changes
Jul 16, 2024
Comment on lines
+15
to
+23
| declare global { | ||
| // eslint-disable-next-line @typescript-eslint/no-namespace | ||
| namespace PrismaJson { | ||
| type SiteJsonConfig = _IsomerSiteConfigProps | ||
| type BlobJsonContent = _IsomerSchema | ||
| type NavbarJsonContent = _IsomerSiteWideComponentsProps["navBarItems"] | ||
| type FooterJsonContent = _IsomerSiteWideComponentsProps["footerItems"] | ||
| } | ||
| } |
There was a problem hiding this comment.
i think @dcshzj had a point about how we had interfaces/types/schemas in our components codebase and
- interfaces were to only be used for our studio codebase to work w/ components
- types is a mix of schema and interfaces (i think???)
- schemas is what we guarantee on our end built site (is a contract between us and end user so we must alw sanitise w/ schema)
There was a problem hiding this comment.
i don't get your point here in this comment. you missing the "so what" portion lol
apps/studio/src/features/editing-experience/components/PageCreateModal.tsx
Outdated
Show resolved
Hide resolved
Huh, but you literally should query with |
karrui
force-pushed
the
move_create_resource_to_menu
branch
from
bad6a32
to
8736c18
Compare
karrui
force-pushed
the
add_types_to_prisma_schema
branch
from
259e0ef
to
2487dcd
Compare
karrui
force-pushed
the
move_create_resource_to_menu
branch
from
8736c18
to
8961126
Compare
karrui
force-pushed
the
add_types_to_prisma_schema
branch
from
2487dcd
to
f33862f
Compare
karrui
force-pushed
the
move_create_resource_to_menu
branch
from
33082d4
to
99c65ae
Compare
karrui
force-pushed
the
add_types_to_prisma_schema
branch
from
15e1632
to
f693207
Compare
type folder contains constants too haha
karrui
force-pushed
the
add_types_to_prisma_schema
branch
from
f693207
to
4817648
Compare
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added the
prisma-json-types-generatormodule to the project and associated it with the JSON columns in the Prisma schema. This enables the usage of strongly typed JSON columns in the database.What changed?
prisma-json-types-generatorversion^3.0.4topackage.jsonandpackage-lock.json.schema.prismato include a new generator forprisma-json-types-generator.types.tsfile to define types for the JSON columns.How to test?
npm install.npx prisma generate.Why make this change?
This change enhances type safety and developer experience by enabling strongly typed JSON columns in the database. It also prepares the project for more advanced features that rely on typed JSON data.