Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show recipient email addresses in share owner notification email #50515

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jan 28, 2025

Previously, the share owner notification email did not display the recipient email addresses, making it difficult for the owner to know who the share was sent to. This fix ensures that the recipient email addresses are included in the notification email.

Before After
image image

@nfebe
Copy link
Contributor Author

nfebe commented Jan 28, 2025

/backport to stable31

@nfebe
Copy link
Contributor Author

nfebe commented Jan 28, 2025

/backport to stable30

@nfebe
Copy link
Contributor Author

nfebe commented Jan 28, 2025

/backport to stable29

@nfebe nfebe requested a review from provokateurin January 29, 2025 11:38
@nfebe nfebe force-pushed the fix/show-share-recipient-in-mail branch from e5ee193 to 9d899c2 Compare January 29, 2025 11:39
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you also added the changes from the other PR

@provokateurin
Copy link
Member

And now it's back to the previous version...

@nfebe
Copy link
Contributor Author

nfebe commented Jan 29, 2025

Now you also added the changes from the other PR

That was fast! 😆 I noticed locally and before coming here you had seen it.

Previously, the share owner notification email did not display the recipient email addresses,
making it difficult for the owner to know who the share was sent to.
This fix ensures that the recipient email addresses are included in the notification email.

Signed-off-by: nfebe <[email protected]>
@nfebe nfebe force-pushed the fix/show-share-recipient-in-mail branch from 9d899c2 to 72b6508 Compare January 29, 2025 11:42
@nfebe nfebe requested a review from susnux January 29, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

3 participants