fix: Send password to owner when password sending fails, regardless of enforcement #50517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
provokateurin
requested changes
Jan 29, 2025
nfebe
force-pushed
the
fix/50512/send-password-2-owner
branch
from
9e6fdc5 to
beacb35
Compare
Previously, the share owner notification email did not display the recipient email addresses, making it difficult for the owner to know who the share was sent to. This fix ensures that the recipient email addresses are included in the notification email. Signed-off-by: nfebe <[email protected]>
…f enforcement Previously, the `sendPasswordToOwner` method would only trigger if password enforcement was enabled and sending the password to the recipient failed. This behavior was inconsistent with the intended functionality, as the owner should receive the password whenever sending to the recipient fails, regardless of whether password enforcement is enabled. This change ensures that the owner is notified of the password whenever sending it to the recipient fails, improving consistency and user experience. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/50512/send-password-2-owner
branch
from
beacb35 to
362ba1a
Compare
|
Needs a rebase (not sure why the other commit still shows up here) and tests need to be adjusted. |
This was branched of the ticket mentioned in the description as "uses".
|
…disabled Signed-off-by: nfebe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
sendPasswordToOwnermethod would only trigger if password enforcement was enabled and sending the password to the recipient failed. This behavior was inconsistent with the intended functionality, as the owner should receive the password whenever sending to the recipient fails, regardless of whether password enforcement is enabled.This change ensures that the owner is notified of the password whenever sending it to the recipient fails, improving consistency and user experience.
Fixes : #50512
Uses : #50515