[stable29] fix: Show recipient email addresses in share owner notification email #50535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
Previously, the share owner notification email did not display the recipient email addresses, making it difficult for the owner to know who the share was sent to. This fix ensures that the recipient email addresses are included in the notification email. Signed-off-by: nfebe <[email protected]>
backportbot
bot
added
3. to review
nfebe
approved these changes
Jan 29, 2025
provokateurin
approved these changes
Jan 29, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -519,7 +519,7 @@ | |||
| $initiator = $this->userManager->get($share->getSharedBy()); | |||
| $initiatorEMailAddress = ($initiator instanceof IUser) ? $initiator->getEMailAddress() : null; | |||
| $initiatorDisplayName = ($initiator instanceof IUser) ? $initiator->getDisplayName() : $share->getSharedBy(); | |||
| $shareWith = $share->getSharedWith(); | |||
| $shareWith = implode(', ', $this->getSharedWithEmails($share)); | |||
Check failure
Code scanning / Psalm
UndefinedMethod Error
nfebe
requested changes
Jan 29, 2025
AndyScherzinger
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #50515