-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demux: add --autocreate-playlist #14555
Conversation
Download the artifacts for this pull request: |
Would it be worth adding a property to distinguish between a playlist that is created with this option? This PR currently will populate the |
I agree, but in the same time I find it quite telling that the playlist was created with a original file being the local file. |
added filtering and docs |
|
While I have never wanted to give a file and have mpv generate a list of files in same directory, there is one thing I want that I think is missing: |
I don't want to mix this changes, this is completely different. For example it would likely be a different option, because you want different filtering for autocreated playlist and different for directory opened directly. |
db2373d
to
e3d60ec
Compare
Added |
Maybe combine normal directory playlists and autocreated?
So you can define the exts for audio/video/images if default is not wanted. This way the options get shorter names and works both for autocreated and for directory created. |
@DanOscarsson: updated. |
cddea0d
to
9ff5144
Compare
|
Thanks guido, should be better now. |
This PR doesn't have feature parity with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. I don't have any further things.
I will merge this later. Honestly I don't have energy to look at this again, let users test it and fix remaining issues as they arrive. |
it breaks RESUMING PLAYBACK
values are saved correctly, but the |
There is also a problem that when opening a single file it creates the playlist normally with --autocreate-playlist=same, but when opening another file in another path it doesn't automatically create the playlist again, which doesn't match the expected behavior. |
Says who? If there is a playlist present already, there will NOT be another one created or otherwise no new items will be appended based on autocreate logic. |
https://github.com/mpv-player/mpv/blob/master/player/loadfile.c#L1682-L1684 We delete the watch_later config if we have a playlist |
This is not quite the same behavior as the autoload.lua script, which creates a new playlist based on the directory of another path when opening a file in another path with
The current behavior does not create a new playlist based on the new path with |
Should be fixed by #14661. Test the build from the PR. |
Yes, it fixes. |
is there an option to automatically add new videos to the playlist if there are new videos in the folder? |
No. |
It's still better to use |
I don't think autoload.lua watches directory for new files. It may load them when the next file is loaded, but it is just an side-effect of how the script work. |
Will there be a feature similar to |
Not tested