Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player/loadfile: don't clear watch later for auto playlist parent file #14661

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

kasper93
Copy link
Contributor

@kasper93 kasper93 commented Aug 11, 2024

No description provided.

@llyyr
Copy link
Contributor

llyyr commented Aug 11, 2024

This prints Resuming playback. This behavior can be disabled with --no-resume-playback. twice when resuming playback

@kasper93
Copy link
Contributor Author

This prints Resuming playback. This behavior can be disabled with --no-resume-playback. twice when resuming playback

Expected. After all we are opening a file, which is converted to opening directory in a demuxer, we have no prior knowledge of that.

@llyyr
Copy link
Contributor

llyyr commented Aug 11, 2024

Expected. After all we are opening a file, which is converted to opening directory in a demuxer, we have no prior knowledge of that.

Yeah, but it'd be nice to fix it since there will definitely be a bug report for this in the future

edit: The same issue will also causes auto profiles that have filename as the condition to be loaded twice, so it's more than just a cosmetic issue now. Use a profile like this to test

@kasper93
Copy link
Contributor Author

The same issue will also causes auto profiles that have filename as the condition to be loaded twice, so it's more than just a cosmetic issue now.

And what is the problem exactly?

@kasper93
Copy link
Contributor Author

Merging this hotfixes, as for the other issue, it need to be evaluated.

@kasper93 kasper93 merged commit e3f426a into mpv-player:master Aug 11, 2024
23 of 24 checks passed
@kasper93 kasper93 deleted the pl_pl branch August 11, 2024 19:06
@llyyr
Copy link
Contributor

llyyr commented Aug 11, 2024

And what is the problem exactly?

Every option inside the profile will be set, restored, then set again everytime the profile-condition evaluates to true. These options can be things that require VO reinit, or require reloading lua scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants