-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute the user-facing scripts under TOOLS #15061
Comments
I'm using shinchiro builds, and it definitely includes what mpv includes by default, in this case Your issue might be that you're still relying on For the built in ### Playlist
autocreate-playlist=filter
directory-filter-types=video,image
directory-mode=ignore
video-exts=3g2,3gp,avi,flv,m2ts,m4v,mj2,mkv,mov,mp4,mpeg,mpg,ogv,rmvb,ts,webm,wmv,y4m
image-exts=avif,bmp,gif,j2k,jp2,jpeg,jpg,jxl,png,svg,tga,tif,tiff,webp
audio-exts=aiff,ape,au,flac,m4a,mka,mp3,oga,ogg,ogm,opus,wav,wma https://mpv.io/manual/master/#options-autocreate-playlist Edit: |
I didn't know the This news greatly alleviates the importance of this request, but the issue remains. All other scripts are still hard to access. |
Oh, you meant the actual If you're worried about missing an updated feature in one of the scripts, then if I may suggest using a daily or weekly git binary, that should keep you up-to-date with everything. |
Can you elaborate how to use the scripts without having the For example, if I download a shinchiro weekly build from Sourceforge, what's the command line I need to use autocrop.lua? I tried |
The scripts at TOOLS are samples or utilities which one might find useful with mpv, maybe as a starting point, or for other reasons. They're not necessarily production quality, they're undocumented, and they're not intended to be shipped with mpv, which is why they're not shipped with mpv. But they can still be useful in some cases, hence they're at the mpv repo. I think this is OK. If you really want to bundle them with in some package, then you should request that from whoever builds and packages it. In this case probably shinchiro's repo at github (but personally I don't think they should be bundled). The mpv team has no control over how it's packaged or distributed. mpv itself is only source code. |
As far as I know, only Any exceptions will depend on the packager/maintainer, mpv itself doesn't do that as explained by avih. |
Understood. Thank you for your input. Closing. |
Scripts in TOOLS are linked in https://github.com/mpv-player/mpv/wiki/User-Scripts so you can find them like any other script, autocrop is the only useful one anyway. @Samillion mpv bundles the scripts in |
autoload is the inspiration of |
Is there a feature to detect newly added videos from downloads to load them when the next file loads? |
There isn't. |
It's not really a big deal, but an opt to |
Expected behavior of the wanted feature
Currently none of the Windows distributions from the Installation page include the scripts under the TOOLS directory, such as "autoload.lua". And I don't find any mentioning of these scripts in the manual. How do we expect people to find them in the first place, without scavenging through the repository? And even though they are not updated that often, there are occasional bug fix and new feature. Suppose user get them from the repo here the first time, do we expect them to regularly re-download, or even git clone the repo with sparse checkout?
Why not copy those user-facing ones (i.e. leaving out those like "test-hooks.lua") into the build output directory, and work with the build maintainers to distribute in the final archive? This way users get to have more tools to work with, and if they care to have them updated regularly all they need to do is to use a daily/weekly build.
This is mostly a Windows and Mac specific issue, since Linux distribute source code anyways, and indeed have the scripts. It wouldn't hurt if we move the strictly internal testing scripts into a different directory to avoid confusion.
Alternative behavior of the wanted feature
A lite version could be simply mention the existence of these scripts, and instruct users to read the comments in the file to understand the usage.
Log File
No response
Sample Files
No response
The text was updated successfully, but these errors were encountered: