Skip to content
Back to pull request #295

refactor: rename IPush and IPull sources to better reflect their purposes #1288

Sign in to view logs

refactor: rename IPush and IPull sources to better reflect their purposes

refactor: rename IPush and IPull sources to better reflect their purposes #1288

Triggered via pull request November 21, 2023 18:03
@cwaldren-ldcwaldren-ld
synchronize #295
cw/rename-push-pull-sources
Status Success
Total duration 2m 28s
Artifacts –
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

cpp-linter.yml

on: pull_request
cpp-linter
2m 2s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

8 errors, 8 warnings, and 1 notice
/libs/server-sdk/src/../include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp:3:10 [clang-diagnostic-error]: libs/server-sdk/src/../include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L3
'launchdarkly/server_side/integrations/serialized_descriptors.hpp' file not found
/libs/server-sdk/src/../include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp:3:10 [clang-diagnostic-error]: libs/server-sdk/src/../include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L3
'launchdarkly/server_side/integrations/serialized_descriptors.hpp' file not found
/libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp:3:10 [clang-diagnostic-error]: libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L3
'launchdarkly/server_side/integrations/serialized_descriptors.hpp' file not found
/libs/server-sdk/src/data_components/serialization_adapters/../kinds/kinds.hpp:3:10 [clang-diagnostic-error]: libs/server-sdk/src/data_components/serialization_adapters/../kinds/kinds.hpp#L3
'launchdarkly/server_side/integrations/serialized_descriptors.hpp' file not found
/libs/server-sdk/src/data_components/serialization_adapters/../kinds/kinds.hpp:3:10 [clang-diagnostic-error]: libs/server-sdk/src/data_components/serialization_adapters/../kinds/kinds.hpp#L3
'launchdarkly/server_side/integrations/serialized_descriptors.hpp' file not found
/libs/server-sdk/src/../include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp:3:10 [clang-diagnostic-error]: libs/server-sdk/src/../include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L3
'launchdarkly/server_side/integrations/serialized_descriptors.hpp' file not found
/libs/server-sdk/src/../include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp:3:10 [clang-diagnostic-error]: libs/server-sdk/src/../include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L3
'launchdarkly/server_side/integrations/serialized_descriptors.hpp' file not found
/libs/server-sdk/src/data_systems/lazy_load/../../data_components/kinds/kinds.hpp:3:10 [clang-diagnostic-error]: libs/server-sdk/src/data_systems/lazy_load/../../data_components/kinds/kinds.hpp#L3
'launchdarkly/server_side/integrations/serialized_descriptors.hpp' file not found
/libs/server-sdk/include/launchdarkly/server_side/config/built/data_system/lazy_load_config.hpp:10:8 [cppcoreguidelines-pro-type-member-init]: libs/server-sdk/include/launchdarkly/server_side/config/built/data_system/lazy_load_config.hpp#L10
constructor does not initialize these fields: eviction_policy
/libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp:58:5 [modernize-use-nodiscard]: libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L58
function 'Get' should be marked [[nodiscard]]
/libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp:70:5 [modernize-use-nodiscard]: libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L70
function 'All' should be marked [[nodiscard]]
/libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp:72:5 [modernize-use-nodiscard]: libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L72
function 'Identity' should be marked [[nodiscard]]
/libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp:74:5 [modernize-use-nodiscard]: libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L74
function 'Initialized' should be marked [[nodiscard]]
/libs/server-sdk/src/data_systems/background_sync/background_sync_system.hpp:27:7 [cppcoreguidelines-special-member-functions]: libs/server-sdk/src/data_systems/background_sync/background_sync_system.hpp#L27
class 'BackgroundSync' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor
/libs/server-sdk/src/data_systems/background_sync/sources/noop/null_data_source.hpp:18:45 [readability-named-parameter]: libs/server-sdk/src/data_systems/background_sync/sources/noop/null_data_source.hpp#L18
all parameters should be named in a function
/libs/server-sdk/src/data_systems/lazy_load/lazy_load_system.hpp:30:7 [cppcoreguidelines-special-member-functions]: libs/server-sdk/src/data_systems/lazy_load/lazy_load_system.hpp#L30
class 'LazyLoad' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor
Run clang-format on libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp: libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp#L1
File libs/server-sdk/include/launchdarkly/server_side/data_interfaces/sources/iserialized_data_reader.hpp does not conform to Custom style guidelines. (lines 34)