refactor: rename IPush and IPull sources to better reflect their purposes #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Nov 21, 2023
| @@ -0,0 +1,39 @@ | |||
| #include "json_data_reader.hpp" | |||
There was a problem hiding this comment.
This is a file renaming, not new content (except for updating the ISerializedDataReader symbol.)
cwaldren-ld
commented
Nov 21, 2023
| @@ -1,16 +1,15 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Since IPullSource is now an IDataReader, it makes sense that the JsonSource is now a JsonDataReader.
keelerm84
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original names were an attempting to retain some symmetry, while also showing that both modes are "sources".
This doesn't need to be the case. These "sources" are conceptual, but have totally different modes of interaction.
I've updated the names to
IDataSynchronizerandIDataReader. These are names that I used in past revisions of the DS spec, and I think they are the better choice today.