-
Notifications
You must be signed in to change notification settings - Fork 1.8k
SC2227
Vidar Holen edited this page Aug 31, 2021
·
2 revisions
find . -name '*.ppm' -exec pnmtopng {} > {}.png \;
find . -name '*.ppm' -exec sh -c 'pnmtopng "$1" > "$1.png"' _ {} \;
ShellCheck detected a find
command with a redirection in the middle.
This redirection may have been intended to apply only to a specific action like -exec
or -print
, but it does in fact apply to the entire find
command:
# This command
find . -name '*.ppm' -exec pnmtopng {} > {}.png \;
# Is the same as this
{
find . -name '*.ppm' -exec pnmtopng {} \;
} > {}.png
To perform a redirection per action, rewrite it with e.g. -exec sh -c '...' _ {} \;
If the redirection is something like > /dev/null
where you don't mind it applying to the whole find
and not individual results, you can move the redirection to the end of command to make it clear to ShellCheck (and humans) that it's not meant per command:
find . -exec foo {} > /dev/null \; # Ambiguous syntax. Is it per -exec or not?
find . -exec foo {} \; > /dev/null # Identical command with clear intent.
There is no difference in behavior between the two.
- Help by adding links to BashFAQ, StackOverflow, man pages, POSIX, etc!