Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and deprecated SCSS #10168

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Conversation

janfaracik
Copy link
Contributor

Small one to remove unused and deprecated SCSS. This includes old button stylings, unused variables and YUI components.

Testing done

  • Searched across GitHub for usages
  • Jenkins looks and behaves the same way

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 16, 2025
@janfaracik janfaracik requested a review from a team January 16, 2025 15:59
--primary-active: #095683;
--danger-hover: #eb383b;
--danger-active: #b50003;
--primary-hover: var(--accent-color);
Copy link
Contributor Author

@janfaracik janfaracik Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related to this PR - but updated these values to use the accent color rather than a custom blue.

@basil
Copy link
Member

basil commented Jan 16, 2025

Might conflict with #10169; if that gets merged first, I can resolve any conflict(s) in this PR.

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jan 16, 2025
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jan 16, 2025
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja requested a review from a team January 16, 2025 22:07
@timja timja added skip-changelog Should not be shown in the changelog and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 16, 2025
@basil basil self-assigned this Jan 16, 2025
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 16, 2025
@timja timja merged commit 7a7293e into jenkinsci:master Jan 17, 2025
16 checks passed
@timja timja deleted the remove-css branch January 17, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants