Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the failures in #10158, I realized we were using the wrong Stylelint configuration: that for plain CSS rather than SCSS. Switching from
stylelint-config-standard
to the more appropriatestylelint-config-standard-scss
allowed us to remove several workarounds in.stylelintrc
and severalmedia-query-no-invalid
ignores, as well as resolving the errors in #10158. Of course, this also turned up a few new violations, but they were all trivial to fix. A number of SCSS rules required adding or removing whitespace or parentheses, or replacing deprecated global methods with newer fine-grained modules.Testing done
mvn clean verify
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist