Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stylelint configuration #10169

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix Stylelint configuration #10169

merged 1 commit into from
Jan 16, 2025

Conversation

basil
Copy link
Member

@basil basil commented Jan 16, 2025

While investigating the failures in #10158, I realized we were using the wrong Stylelint configuration: that for plain CSS rather than SCSS. Switching from stylelint-config-standard to the more appropriate stylelint-config-standard-scss allowed us to remove several workarounds in .stylelintrc and several media-query-no-invalid ignores, as well as resolving the errors in #10158. Of course, this also turned up a few new violations, but they were all trivial to fix. A number of SCSS rules required adding or removing whitespace or parentheses, or replacing deprecated global methods with newer fine-grained modules.

Testing done

mvn clean verify

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@basil basil added the skip-changelog Should not be shown in the changelog label Jan 16, 2025
@basil basil requested a review from a team January 16, 2025 16:25
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern krisstern requested a review from a team January 16, 2025 16:28
Copy link
Contributor

@janfaracik janfaracik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, LGTM!

@basil
Copy link
Member Author

basil commented Jan 16, 2025

De minimis; expediting to unblock #10168.

@basil basil merged commit 8d78437 into jenkinsci:master Jan 16, 2025
10 of 14 checks passed
@basil basil deleted the scss branch January 16, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants