Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and deprecated SCSS #10168

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Remove unused and deprecated SCSS #10168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4905a0
Init
janfaracik Jan 16, 2025
c239daa
Update _page-header.scss
janfaracik Jan 16, 2025
ee1b20b
Remove YUI styling
janfaracik Jan 16, 2025
99e32bd
Merge remote-tracking branch 'origin/master' into remove-css
basil Jan 16, 2025
312f977
Little bit more
janfaracik Jan 16, 2025
2839ea5
Update _app-bar.scss
janfaracik Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 3 additions & 75 deletions src/main/scss/abstracts/_theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,9 @@ $semantics: (
--focus-input-border: var(--accent-color);
--focus-input-glow: color-mix(in sRGB, var(--accent-color) 15%, transparent);

// Deprecated
--focus-btn-primary: #{color.change(#0b6aa2, $alpha: 0.5)};
--focus-btn-secondary: #{color.change(#0b6aa2, $alpha: 0.5)};
--focus-btn-danger: #{color.change(#cc0003, $alpha: 0.5)};

// State colors
--primary-hover: #0587d4;
--primary-active: #095683;
--danger-hover: #eb383b;
--danger-active: #b50003;
--primary-hover: var(--accent-color);
Copy link
Contributor Author

@janfaracik janfaracik Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related to this PR - but updated these values to use the accent color rather than a custom blue.

--primary-active: var(--accent-color);

// Status icon colors
--weather-icon-color: var(--accent-color);
Expand All @@ -77,16 +70,9 @@ $semantics: (
// Header
--brand-link-color: var(--secondary);
--header-link-color: var(--white);
--header-link-color-active: #f5f5f5;
--header-search-border: var(--white);
--search-input-color: var(--brand-link-color);
--search-bg: var(--white);
--search-box-completion-bg: var(--primary-hover);
--search-box-shadow: 0 1px 7px 0 rgb(0 0 0 / 0.3);
--header-bg-classic: var(--black);
--header-link-bg-classic-hover: #404040;
--header-link-bg-classic-active: #404040;
--header-item-border-radius: 4px;

// Breadcrumbs bar
--breadcrumbs-bar-background: oklch(
Expand Down Expand Up @@ -138,42 +124,6 @@ $semantics: (
// Typography
--text-color-secondary: var(--secondary);

// Deprecated - Button generic
--btn-font-weight: bold;
--btn-text-color: var(--white);
--btn-font-size: var(--font-size-xs);
--btn-line-height: 1rem;
--btn-large-font-size: var(--font-size-sm);
--btn-large-line-height: 1.25rem;

// Deprecated - Button primary
--button-color--primary: var(--background);
--btn-primary-bg: #063f61;
--btn-primary-bg-hover: #{color.adjust(#063f61, $lightness: 7.5%)};
--btn-primary-bg-active: #{color.adjust(#063f61, $lightness: 12%)};

// Deprecated - Button primary
--btn-secondary-color: var(--secondary);
--btn-secondary-bg: var(--btn-text-color);
--btn-secondary-border: var(--medium-grey);
--btn-secondary-color--hover: var(--accent-color);
--btn-secondary-bg--hover: var(--btn-secondary-bg);
--btn-secondary-border--hover: var(--accent-color);
--btn-secondary-color--focus: var(--accent-color);
--btn-secondary-bg--focus: var(--btn-secondary-bg);
--btn-secondary-border--focus: var(--accent-color);
--btn-secondary-color--active: var(--primary-active);
--btn-secondary-bg--active: var(--btn-secondary-bg);
--btn-secondary-border--active: var(--primary-active);

// Deprecated - Button link
--btn-link-color: var(--accent-color);
--btn-link-font-weight: var(--link-font-weight);
--btn-link-color--hover: var(--primary-hover);
--btn-link-bg--hover: var(--very-light-grey);
--btn-link-color--active: var(--primary-active);
--btn-link-bg--active: var(--light-grey);

// Table
--table-background: oklch(from var(--text-color-secondary) l c h / 0.1);
--table-header-foreground: var(--text-color);
Expand Down Expand Up @@ -282,18 +232,10 @@ $semantics: (
--tabs-item-foreground--selected: var(--link-color);
--tabs-border-radius: calc((10px + 34px) / 2);

// Deprecated - Tabbar baseline
--tab-baseline-width: 2px;
--tab-baseline-color: var(--light-grey);
--tab-baseline-default-display: none;

// Side panel
--side-panel-width: 340px;
--panel-header-bg-color: var(--light-grey);
--panel-border-color: var(--light-grey);
--side-panel-hover-color: var(--panel-border-color);
--task-link-bg-color--active: var(--panel-border-color);
--task-link-bg-color--hover: var(--very-light-grey);

// Form
--section-padding: 1.625rem;
Expand Down Expand Up @@ -337,24 +279,9 @@ $semantics: (
--standard-transition: 0.3s ease;
--elastic-transition: 0.3s cubic-bezier(0, 0.68, 0.5, 1.5);

// Deprecated - Pop out menus
--menu-text-color: black;
--menu-bg-color: var(--white);
--menu-selected-color: #b3d4ff;
--menu-box-shadow: 0 3px 10px rgb(0 0 0 / 0.3);

// Deprecated - Add form widget / configure job
--light-bg-color: #eee;
--light-bg-color--hover: rgb(255 255 255 / 0.65);
--add-item-btn-decorator-border-color: #acb;
--add-item-btn-decorator-bg-color: rgb(245 249 239 / 0.75);

// Plugin manager
--plugin-manager-bg-color-already-upgraded: var(--light-grey);

// Auto complete
--auto-complete-bg-color--prehighlight: #b3d4ff;

// Default button
--button-background: oklch(from var(--text-color-secondary) l c h / 0.075);
--button-background--hover: oklch(
Expand All @@ -366,6 +293,7 @@ $semantics: (
--button-box-shadow--focus: oklch(
from var(--text-color-secondary) l c h / 0.1
);
--button-color--primary: var(--background);

// Variables for sidebar items, card items
--item-background--hover: oklch(from var(--text-color-secondary) l c h / 0.1);
Expand Down
39 changes: 0 additions & 39 deletions src/main/scss/base/_style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,6 @@ pre.console {
margin-top: 0;
}

.setting-main > .yui-button {
clear: both;
float: right;
}

.expanding-input {
display: flex;
align-items: center;
Expand Down Expand Up @@ -272,22 +267,6 @@ pre.console {
color: gray;
}

.bottom-sticker,
#bottom-sticker {
position: sticky;

// This has to be set to -1px so that IntersectionObserver can add the
// &--stuck class when the element is stuck to the bottom of the screen
// https://css-tricks.com/how-to-detect-when-a-sticky-element-gets-pinned/
bottom: -1px;
margin-left: calc(var(--section-padding) * -1);
width: calc(
100% + calc(var(--section-padding) * 2)
); /* it needs to occupy the entire width or else the underlying content will see through */

z-index: 998; /* behind top-sticker */
}

.icon16x16 {
width: 16px;
height: 16px;
Expand Down Expand Up @@ -403,20 +382,6 @@ img.icon-help {
display: block;
}

/* ================ Element overflow calculation helper styles ================ */

.force-wrap,
.force-wrap a {
white-space: normal !important;
overflow: visible !important;
}

.force-nowrap,
.force-nowrap a {
white-space: nowrap !important;
overflow: hidden !important;
}

/* ========================= editable combobox style ========================= */
.comboBoxList {
overflow-y: scroll;
Expand Down Expand Up @@ -795,10 +760,6 @@ select.select-ajax-pending {
}

/* ========================= Button styles ================= */
#disable-project {
margin-top: 6px;
}

.i18n {
display: none;
}
Expand Down
16 changes: 16 additions & 0 deletions src/main/scss/components/_app-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,22 @@
}
}

.bottom-sticker,
#bottom-sticker {
position: sticky;

// This has to be set to -1px so that IntersectionObserver can add the
// &--stuck class when the element is stuck to the bottom of the screen
// https://css-tricks.com/how-to-detect-when-a-sticky-element-gets-pinned/
bottom: -1px;
margin-left: calc(var(--section-padding) * -1);
width: calc(
100% + calc(var(--section-padding) * 2)
); /* it needs to occupy the entire width or else the underlying content will see through */

z-index: 998; /* behind top-sticker */
}

.bottom-sticker-inner {
position: relative;
padding: 1em var(--section-padding);
Expand Down
27 changes: 0 additions & 27 deletions src/main/scss/components/_breadcrumbs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,30 +311,3 @@
}
}
}

// TODO: Remove when YUI dropdowns are removed

#breadcrumb-menu .header {
font-weight: bold;
font-size: 0.875rem;
pointer-events: none;
}

#breadcrumb-menu .separator {
position: relative;
display: block !important;
color: transparent;
overflow: hidden;
width: 100%;

&::after {
content: "";
position: absolute;
top: 9px;
left: -50vw;
right: -50vw;
background: var(--text-color);
height: 2px;
opacity: 0.1;
}
}
111 changes: 0 additions & 111 deletions src/main/scss/components/_buttons-deprecated.scss
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/main/scss/components/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
@use "badges";
@use "breadcrumbs";
@use "buttons";
@use "buttons-deprecated";
@use "cards";
@use "command-palette";
@use "content-blocks";
Expand Down
Loading
Loading