Update to latest GLFW

[errissa]

Type

• Bug fix (non-breaking change which fixes an issue): Fixes #
• New feature (non-breaking change which adds functionality). Resolves #
• Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Updates Open3D to use the latest GLFW as the version we had been using is several years old and predates Mac API changes. Also, updated to build system to build GLFW as external project to make it consistent with the rest of Open3D's use of third party libraries.

Checklist:

• I have run python util/check_style.py --apply to apply Open3D code style
  to my code.
• This PR changes Open3D behavior or adds new functionality.
  • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
    updated accordingly.
  • I have added or updated C++ and / or Python unit tests OR included test
    results (e.g. screenshots or numbers) here.
• I will follow up and update the code if CI fails.
• For fork PRs, I have selected Allow edits from maintainers.

Description

[update-docs]

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

[ssheorey]

Looks good. We can merge after testing. Thanks!

[ssheorey]

Possibly fixes #1673

[ssheorey]

Test draw example and O3DVisualizer. Also test legacy visualizer.

[ssheorey]

Hi @errissa can you check the error in the documentation CI? Also, do all examples run for you? I got a crash in one draw.py example on Intel macOS.

[ssheorey]

Works for me on intel Mac now.

[ssheorey]

Everything works, except double clicking on a file in macOS does not open the file with Open3D. Need to check how macOS is passing the file name to glfw.

[ssheorey]

Hi @errissa let's go ahead and merge this PR and the filament update PR as is. We'll open an issue for the "double clicking on file doesn't open in Open3D viewer" and fix it later.

[ssheorey]

FIXME: Intel macOS: No window when opening app without a file (e.g. double click).

[rxba]

Not sure if this was still was an open question, but this PR does indeed fix #1673 on an M3 Mac.

[ssheorey]

@rxba thanks for testing this PR. We haven't merged this yet because of a macOS [only tested on Intel mac] issue in the Open3D viewer, where double clicking on the app, or launching from the command line doesn't bring up an empty window. Trying to open an asosciated file (double click or command line) gives an error instead of opening it. Can you test and see if you get this error on your Apple M3 machine?

[ssheorey]

FIXME: Intel macOS: No window when opening app without a file (e.g. double click).

@errissa when you get a chance, can you take a look at this? Thanks!

[rxba]

@ssheorey Can confirm this is also an issue on ARM Mac. I just tried ./build/bin/Open3D.app/Contents/MacOS, which does open the window on the current main branch, but does not open it on this PR branch.
Not sure what you mean with "opening an associated file", but I'd assume the behaviour is also the same on ARM.

[ssheorey]

You can make Open3D the default viewer for 3D file types (gltf, obj, ply, etc.), so that double clicking on the file opens it in Open3D. With this PR, you instead get an error message box saying cannot open file of type GLTF, etc.

[rxba]

You can make Open3D the default viewer for 3D file types (gltf, obj, ply, etc.), so that double clicking on the file opens it in Open3D. With this PR, you instead get an error message box saying cannot open file of type GLTF, etc.

I see, can confirm the same behaviour on ARM, e.g. opening a .ply on this build errors with The document "...ply" could not be opened. cannot open files in the "Polygon File Format" format., while it opens the viewer fine with the main branch built binary.

[cwreynolds]

Sorry to be off-topic for this thread, but as described in #7000 I have been unable to run a new app written in c++ using open3d::visualization::gui::Application on macOS. I am looking for example code. Above, @rxba mentioned build/bin/Open3D.app which may be a good example to follow. I would be grateful if anyone could glance at #7000 and give me a clue.