WIP: python311Packages.nerfstudio: init at 1.1.2 #320599
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| description = "The devkit of the nuScenes dataset"; | ||
| homepage = "https://github.com/nutonomy/nuscenes-devkit"; | ||
| license = lib.licenses.asl20; | ||
| maintainers = with lib.maintainers; [ SomeoneSerge ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = with lib.maintainers; [ SomeoneSerge ]; | |
| maintainers = with lib.maintainers; [ SomeoneSerge ]; |
SomeoneSerge
commented
Oct 31, 2024
There was a problem hiding this comment.
One blocker less, seems like isl-org/Open3D#6809 was merged
There was a problem hiding this comment.
Would be almost trivial if not for
GaetanLepage
requested changes
Oct 31, 2024
| src = fetchFromGitHub { | ||
| owner = "microsoft"; | ||
| repo = "DirectXMath"; | ||
| rev = "feb2024"; |
There was a problem hiding this comment.
Suggested change
| rev = "feb2024"; | |
| rev = "refs/tags/feb2024"; |
| src = fetchFromGitHub { | ||
| owner = "google"; | ||
| repo = "filament"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "v${version}"; | |
| rev = "refs/tags/v${version}"; |
| (lib.cmakeFeature "FILAMENT_OPENGL_HANDLE_ARENA_SIZE_IN_MB" "20") | ||
| ]; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| meta = { |
| ]; | ||
|
|
||
| meta = with lib; { | ||
| description = "Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2"; |
There was a problem hiding this comment.
Suggested change
| description = "Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2"; | |
| description = "Real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2"; |
| description = "Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2"; | ||
| homepage = "https://github.com/google/filament"; | ||
| license = licenses.asl20; | ||
| maintainers = with maintainers; [ ]; |
There was a problem hiding this comment.
Why don't you add yourself ?
| description = "CUDA accelerated rasterization of gaussian splatting"; | ||
| homepage = "https://github.com/nerfstudio-project/gsplat"; | ||
| license = licenses.asl20; | ||
| maintainers = with maintainers; [ ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = with maintainers; [ ]; | |
| maintainers = with maintainers; [ SomeoneSerge ]; |
| src = fetchFromGitHub { | ||
| owner = "nerfstudio-project"; | ||
| repo = "nerfacc"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "v${version}"; | |
| rev = "refs/tags/v${version}"; |
| meta = { | ||
| description = "A General NeRF Acceleration Toolbox in PyTorch"; | ||
| homepage = "https://github.com/nerfstudio-project/nerfacc"; | ||
| changelog = "https://github.com/nerfstudio-project/nerfacc/blob/${src.rev}/CHANGELOG.md"; |
There was a problem hiding this comment.
Suggested change
| changelog = "https://github.com/nerfstudio-project/nerfacc/blob/${src.rev}/CHANGELOG.md"; | |
| changelog = "https://github.com/nerfstudio-project/nerfacc/blob/${lib.removePrefix "refs/tags/" src.rev}/CHANGELOG.md"; |
There was a problem hiding this comment.
this fix only applies to release pages, not for blobs
| src = fetchFromGitHub { | ||
| owner = "nerfstudio-project"; | ||
| repo = "nerfstudio"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "v${version}"; | |
| rev = "refs/tags/v${version}"; |
Comment on lines
+199
to
+200
| homepage = "https://github.com/nerfstudio-project/nerfstudio"; | ||
| license = lib.licenses.asl20; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/nerfstudio-project/nerfstudio"; | |
| license = lib.licenses.asl20; | |
| homepage = "https://github.com/nerfstudio-project/nerfstudio";* | |
| changelog = "https://github.com/nerfstudio-project/nerfstudio/releases/tag/v${version}"; | |
| license = lib.licenses.asl20; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
python311Packages.nerfstudio: init at 1.1.2open3d: init at 0.18.0Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.