Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SetFullScreen to GUI::Window and GLFWWindowSystem #5936

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yankailab
Copy link

@yankailab yankailab commented Feb 20, 2023

Added SetFullScreen function to GUI::Window, WindowSystem and GLFWWindowSystem, so that classes inherits GUI::Window can set to full screen mode easily.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

We would create custom UI classes that inherits the GUI::Window. With the added SetFullScreen interface the UI classes can easily switch to full screen mode and back.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Feb 20, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@errissa errissa self-requested a review February 20, 2023 13:21
@errissa
Copy link
Collaborator

errissa commented Feb 20, 2023

Hi @yankailab. Thank you for submitting this PR. I notice that you closed your old PR for this feature. Please add Python bindings for the new SetFullScreen method. If you need help with that please let me know.

@ssheorey
Copy link
Member

Needs testing on all platforms and Python bindings.

@ssheorey
Copy link
Member

FIXME: Crash in macOS on activating full screen.

@ssheorey
Copy link
Member

Retest PR after GLFW upgrade PR (#6587 ) is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants