Fix Typo and Correct Object Attribute in BBS signature computation #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have reviewed the updates, and everything looks good to me, except for two minor points that this PR addresses:
draft-ietf-jose-json-proof-algorithms.md
In the
bbs.fixtures.mjs
file, the BBS sign function was called with an object containing a 'payloads' property. However, the sign function is designed to accept input objects of type "BbsSignRequest", which require a 'messages' property. Providing an object with a 'payloads' property instead resulted in the 'messages' property being set to 'undefined'.No issues were immediately visible because, the BBS scheme allows empty message arrays for signing operations.
Internally, the 'sign' operation accessed the 'messages' property, which was "undefined". So basically, It successfully computed the signature over an empty array of messages.
If you test the current code as it is and pass to the function an empty array of payloads you will notice that it produces the same signature value. Additionally, if you set
verifySignature: true
in the deriveProof function, the signature verification would fail, as the messages are correctly passed to the function in this case.