Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo and Correct Object Attribute in BBS signature computation #88

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Fix Typo and Correct Object Attribute in BBS signature computation #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
101bd0c
Fix typo: corrected 'holder' to 'verifier'
AlbertoSvg Oct 22, 2023
f17c15b
Fix signature computation in bbs-fixtures
AlbertoSvg Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion draft-ietf-jose-json-proof-algorithms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ Figure: Presentation JWP (compact serialization)

### Presentation Verification

Verification of a presentation is done by the holder using the `ProofVerify` operation from [@!I-D.irtf-cfrg-bbs-signatures, Section 3.4.4].
Verification of a presentation is done by the verifier using the `ProofVerify` operation from [@!I-D.irtf-cfrg-bbs-signatures, Section 3.4.4].

This operation utilizes the issuer's public key as `PK`, the issuer protected header as `header`, the issuance proof as `signature`, the holder's presentation protected header as `ph`, and the payloads as `disclosed_messages`.

Expand Down
2 changes: 1 addition & 1 deletion fixtures/bbs-fixtures.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const signature = await pairing.bbs.bls12381_sha256.sign({
publicKey: keyPair.publicKey,
secretKey: keyPair.secretKey,
header: protectedHeader,
payloads: payloads
messages: payloads
});

await fs.writeFile("build/bbs-issuer-proof.base64url", encode(signature), {encoding: "UTF-8"});
Expand Down