Fixing Compact Serialization and Presentation Header Handling in BBS Algorithm Example #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Everyone,
I submitted this pull request to address what I believe is an error in the BBS algorithm example in the JPA draft. In the provided presented JWP representation, there is only one "protected" header referring to the issued protected header. However, according to section 6.2.6 of this draft and section 4.2.1 of the JWP draft, there should also be a presentation protected header containing the nonce used for the generation and verification of the proof used to present the JWP to a Verifier.
Additionally, I corrected the encoding of the protected headers during "compact serialization." The header value present in the JSON representation had already undergone the UTF-8 and base64url encoding process. However, in the compact serialization, instead of taking it as it is, the header value was mistakenly enclosed in quotation marks
and then base64url encoded again.
As a final step, I modified the "fixtures_bbs-x.js" file to handle the presentation protected header.