Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help wanted: fix missing translation strings #127811

Open
57 of 84 tasks
epenet opened this issue Oct 7, 2024 · 8 comments
Open
57 of 84 tasks

Help wanted: fix missing translation strings #127811

epenet opened this issue Oct 7, 2024 · 8 comments
Labels
help-wanted Wanna help? Jump in!

Comments

@epenet
Copy link
Contributor

epenet commented Oct 7, 2024

The problem

As a developper, it's very easy to forget adding all expected translation keys into strings.json
I am working on catching this within the regular test routines (see #127787)

If you would like to help, take a look at the resulting failures and see if you can add/fix:
https://github.com/home-assistant/core/pull/127787/checks

Tasks

@mib1185
Copy link
Contributor

mib1185 commented Oct 7, 2024

These are all open ones (without a pending PR)

...

Edit: converted to task list in the description

@epenet
Copy link
Contributor Author

epenet commented Oct 9, 2024

we have some integrations (eq. generic and webmin, properly much more) which redirects possible connection errors direct into the errors dict to the async_show_form, those they can have unexpected or unforeseen error values, which can't be translated 🤔 Should we adjust the tests in this case, so they test only expected errors? Or do we've the possibility to work with placeholders also for errors in flow forms?

Might be worth confirming with a core member...
I think we normally use "unknown" and log the full details

@gjohansson-ST
Copy link
Member

I think we normally use "unknown" and log the full details

Like that yes, we can only translate known errors e.g. there is no placeholders or such.

@epenet
Copy link
Contributor Author

epenet commented Oct 14, 2024

I've updated the task list to remove (at least temporarily) the data strings, and add the latest PRs from @j4n-e4t

@j4n-e4t
Copy link
Contributor

j4n-e4t commented Oct 15, 2024

@epenet Do you have a way to get all components that still have the ignore_translations rule in the config_flow tests? Should I go through them and file a PR removing them for the merged ones?
I found quite some components still having such rule in place, even if the translation is added correctly. Also my merged PRs from yesterday.

@epenet
Copy link
Contributor Author

epenet commented Oct 15, 2024

@epenet Do you have a way to get all components that still have the ignore_translations rule in the config_flow tests? Should I go through them and file a PR removing them for the merged ones? I found quite some components still having such rule in place, even if the translation is added correctly. Also my merged PRs from yesterday.

I've opened #128441 to remove them all
There was a gap in the previous detection logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Wanna help? Jump in!
Projects
None yet
Development

No branches or pull requests

4 participants