Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation string in spotify #128440

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

j4n-e4t
Copy link
Contributor

@j4n-e4t j4n-e4t commented Oct 15, 2024

Breaking change

Proposed change

Add missing translation string to spotify integration.
Links to #127811

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @frenck, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (spotify) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of spotify can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign spotify Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the translation checks - please also remove the ignore in the test

@pytest.mark.parametrize( # Remove when translations fixed
"ignore_translations",
["component.spotify.config.abort.missing_credentials"],
)

@epenet epenet closed this Oct 15, 2024
@epenet epenet reopened this Oct 15, 2024
@j4n-e4t
Copy link
Contributor Author

j4n-e4t commented Oct 15, 2024

@epenet Is the ignore_translations in other config_flow tests as well? (Should I remove it on any other PR?)

@epenet
Copy link
Contributor

epenet commented Oct 15, 2024

@epenet Is the ignore_translations in other config_flow tests as well? (Should I remove it on any other PR?)

The ignore_translations was added for all config.abort.*, but not for config.error.* etc.
So yes, it may need removing on the other PRs

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet merged commit 260d919 into home-assistant:dev Oct 15, 2024
31 checks passed
@j4n-e4t j4n-e4t deleted the j4n-e4t/translations-spotify branch October 15, 2024 12:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants