-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translation string in weatherflow #128321
Fix translation string in weatherflow #128321
Conversation
Hey there @natekspencer, @jeeftor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -13,7 +13,8 @@ | |||
}, | |||
"error": { | |||
"address_in_use": "Unable to open local UDP port 50222.", | |||
"cannot_connect": "UDP discovery error." | |||
"cannot_connect": "UDP discovery error.", | |||
"no_devices_found": "[%key:common::config_flow::abort::no_devices_found%]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a reference to abort::no_devices_found
or should we add a new key under error in the main strings.json
. (Reason: The text is exactly the same and it would be a duplicate.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not duplicate so I think this is fine 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @j4n-e4t 👍
Sadly this wasn't quite right (should have been device singular)... |
Breaking change
Proposed change
Add missing translation string to weatherflow integration.
Links to #127811
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: