Fix translation string in weatherflow #128321
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
Hacktoberfest
integration: weatherflow
small-pr
|
Hey there @natekspencer, @jeeftor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
j4n-e4t
commented
Oct 13, 2024
| @@ -13,7 +13,8 @@ | |||
| }, | |||
| "error": { | |||
| "address_in_use": "Unable to open local UDP port 50222.", | |||
| "cannot_connect": "UDP discovery error." | |||
| "cannot_connect": "UDP discovery error.", | |||
| "no_devices_found": "[%key:common::config_flow::abort::no_devices_found%]" | |||
There was a problem hiding this comment.
Should this be a reference to abort::no_devices_found or should we add a new key under error in the main strings.json. (Reason: The text is exactly the same and it would be a duplicate.)
There was a problem hiding this comment.
Let's not duplicate so I think this is fine 👍
tetele
pushed a commit
to tetele/ha-core
that referenced
this pull request
Oct 14, 2024
|
Sadly this wasn't quite right (should have been device singular)... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add missing translation string to weatherflow integration.
Links to #127811
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: