Solved bug with incompatible QoS policies (second try) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudoroancea
changed the title
achim-k
reviewed
Dec 12, 2023
| @@ -94,7 +94,7 @@ static foxglove::Parameter fromRosParam(const rclcpp::Parameter& p) { | |||
| } else if (type == rclcpp::ParameterType::PARAMETER_BOOL_ARRAY) { | |||
| std::vector<foxglove::ParameterValue> paramVec; | |||
| for (const auto value : p.as_bool_array()) { | |||
| paramVec.push_back(value); | |||
| paramVec.push_back(foxglove::ParameterValue(value)); | |||
There was a problem hiding this comment.
This change was already commited in #277, can you remove it from this PR? Not sure why it isn't shown as conflicting.
There was a problem hiding this comment.
I based this branch on the one I created from #277 (to be able to compile the code and test it on my mac), that's why the same commit appears
achim-k
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Solved bug with incompatible QoS policies
Description
Fixes the following issue