Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Bump bbolt to 1.3.11 #18488

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

akshaym-3255
Copy link
Contributor

@akshaym-3255 akshaym-3255 commented Aug 23, 2024

Fixes [#18480]

@k8s-ci-robot
Copy link

Hi @akshaym-3255. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akshaym-3255
Copy link
Contributor Author

/test

@k8s-ci-robot
Copy link

@akshaym-3255: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmhbnz
Copy link
Member

jmhbnz commented Aug 23, 2024

/ok-to-test

@jmhbnz
Copy link
Member

jmhbnz commented Aug 23, 2024

/retitle [3.4] Bump bbolt to 1.3.11

@k8s-ci-robot k8s-ci-robot changed the title bump bbolt to 1.3.11 for 3.4 [3.4] Bump bbolt to 1.3.11 Aug 23, 2024
@ivanvc
Copy link
Member

ivanvc commented Aug 24, 2024

@jmhbnz, but now, for sure, in this one, the GitHub workflows didn't trigger 😅

@jmhbnz
Copy link
Member

jmhbnz commented Aug 24, 2024

@jmhbnz, but now, for sure, in this one, the GitHub workflows didn't trigger 😅

Happens sometimes if actions is having issues. Triggered them manually :)

go.sum Outdated
Comment on lines 174 to 175
go.etcd.io/bbolt v1.3.10 h1:+BqfJTcCzTItrop8mq/lbzL8wSGtj94UO/3U31shqG0=
go.etcd.io/bbolt v1.3.10/go.mod h1:bK3UQLPJZly7IlNmV7uVHJDxfe5aK9Ll93e/74Y9oEQ=
go.etcd.io/bbolt v1.3.11 h1:yGEzV1wPz2yVCLsD8ZAiGHhHVlczyC9d1rP43/VCRJ0=
go.etcd.io/bbolt v1.3.11/go.mod h1:dksAq7YMXoljX0xu6VF5DMZGbhYYoLUalEiSySYAS4I=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request, Akshay. Can you run go mod tidy and commit the resulting go.sum? The reference to v1.3.10 should disappear. You can amend your commit and force push to have only one commit.

Thanks again :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ivanvc ivanvc mentioned this pull request Aug 25, 2024
2 tasks
Signed-off-by: akshaym-3255 <[email protected]>
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot, Akshay!

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, akshaym-3255, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 394164e into etcd-io:release-3.4 Aug 25, 2024
18 checks passed
@ivanvc ivanvc mentioned this pull request Sep 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants