Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Bump bbolt to 1.3.11 #18489

Merged
merged 1 commit into from
Aug 25, 2024
Merged

[3.5] Bump bbolt to 1.3.11 #18489

merged 1 commit into from
Aug 25, 2024

Conversation

akshaym-3255
Copy link
Contributor

@akshaym-3255 akshaym-3255 commented Aug 23, 2024 •
edited
Loading

Fixes [#18480]

@k8s-ci-robot
Copy link

Hi @akshaym-3255. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmhbnz
Copy link
Member

jmhbnz commented Aug 23, 2024

/ok-to-test

@jmhbnz
Copy link
Member

jmhbnz commented Aug 23, 2024

/retitle [3.5] Bump bbolt to 1.3.11

@k8s-ci-robot k8s-ci-robot changed the title bump bbolt to 1.3.11 for 3.5 [3.5] Bump bbolt to 1.3.11 Aug 23, 2024
@akshaym-3255
bump bbolt to 1.3.11 for 3.5
b7548ca 
Signed-off-by: akshaym-3255 <[email protected]>

bump bbolt to 1.3.11 for 3.5
ivanvc
ivanvc approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (on green). Thanks, Akshay.

@ivanvc
Copy link
Member

ivanvc commented Aug 24, 2024 •
edited
Loading

@jmhbnz, looks like the prow tests for this pull request and #18488 weren't triggered even after /ok-to-test. I know that sometimes they get triggered when you close and open the pull request. I'd do it, but I don't know if I can reopen them.

Never mind, my brain is tired 😂 we don't have prow jobs for release-3.5 yet.

@ivanvc
Copy link
Member

ivanvc commented Aug 24, 2024

/test all

@k8s-ci-robot
Copy link

@ivanvc: No presubmit jobs available for etcd-io/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jmhbnz
jmhbnz approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @akshaym-3255

@ivanvc ivanvc mentioned this pull request Aug 25, 2024
Closed
2 tasks
ahrtr
ahrtr approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, akshaym-3255, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit f739ef4 into etcd-io:release-3.5 Aug 25, 2024
27 checks passed
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 25, 2024
@ahrtr @aneesh1
Merge pull request etcd-io#18489 from akshaym-3255/bboltbump3.5_1.3.11
2fa4807 
[3.5] Bump bbolt to 1.3.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees
No one assigned
Labels
approved ok-to-test size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akshaym-3255 @k8s-ci-robot @jmhbnz @ivanvc @ahrtr