Plan to release etcd v3.4.34 #18486

ivanvc · 2024-08-22T22:48:03Z

What would you like to be added?

The etcd patch release criteria has been met for our release-3.4 stable release branch so we should release v3.4.34.

The list of commits included since the previous release is: v3.4.33...release-3.4:

Work in progress CHANGELOG is: https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.4.md#v3434-tbd

List of pull requests we still need to backport from `main` to `release-3.4` before the patch release is issued:

Update Go main branch to 1.23.1 release branches to 1.22.7 #18548

Release team

GitHub handle	Role
@ivanvc	Release lead
@ahrtr	Release advisor
@henrybear327	Release shadow

Why is this needed?

Regular patch releases are vital to ensure our users have bug-free and secure software.

The text was updated successfully, but these errors were encountered:

serathius · 2024-09-03T11:17:52Z

@ivanvc any blockers for release that I can help with?

ahrtr · 2024-09-03T12:34:51Z

@ivanvc please feel free to drive/lead the release process, thx cc @jmhbnz

henrybear327 · 2024-09-03T13:38:57Z

@ivanvc can I shadow this release :) Thank you!

ivanvc · 2024-09-03T19:52:33Z

@serathius, @ahrtr, no blockers. I was a bit busy the last weeks so that I couldn't follow up on the releases.

That being said, I'm happy to lead this release. Since we did the last release, we need to get a list of pull requests/issues that require a backport. @henrybear327, can you help me do a pass over them? I'll also do one. I'm checking at issues from the next list: https://github.com/etcd-io/etcd/issues?page=1&q=is%3Aissue+label%3Atype%2Fbug+created%3A%3E%3D2024-06-14, and pull requests from: https://github.com/etcd-io/etcd/issues?q=is%3Apullrequest+label%3Atype%2Fbug+created%3A%3E%3D2024-06-14

@ahrtr, @jmhbnz, @serathius, @spzala, @wenjiaswe, with me as the release lead, would any of you want to be emeritus lead, advisor, or shadow? Given that it will be my first release, I'd appreciate guidance from someone.

ivanvc · 2024-09-04T04:47:47Z

I see that we have this issue with an open PR marked as backport to v3.4 and v3.5: #18267. Do we want to merge its PR (#18268)? It looks like it never got a review.

ahrtr · 2024-09-04T06:58:14Z

Do we want to merge its PR (#18268)?

NO, the PR changes the most important part of etcdserver, but without proper test cases. Since it's low priority/impact, we can revisit it in future when we have bandwidth.

ahrtr · 2024-09-04T07:04:06Z

@ahrtr, @jmhbnz, @serathius, @spzala, @wenjiaswe, with me as the release lead, would any of you want to be emeritus lead, advisor, or shadow? Given that it will be my first release, I'd appreciate guidance from someone.

I am happy to join the release meeting for 3.4.34 this time. Thanks

henrybear327 · 2024-09-04T19:20:16Z

@serathius, @ahrtr, no blockers. I was a bit busy the last weeks so that I couldn't follow up on the releases.

That being said, I'm happy to lead this release. Since we did the last release, we need to get a list of pull requests/issues that require a backport. @henrybear327, can you help me do a pass over them? I'll also do one. I'm checking at issues from the next list: https://github.com/etcd-io/etcd/issues?page=1&q=is%3Aissue+label%3Atype%2Fbug+created%3A%3E%3D2024-06-14, and pull requests from: https://github.com/etcd-io/etcd/issues?q=is%3Apullrequest+label%3Atype%2Fbug+created%3A%3E%3D2024-06-14

@ahrtr, @jmhbnz, @serathius, @spzala, @wenjiaswe, with me as the release lead, would any of you want to be emeritus lead, advisor, or shadow? Given that it will be my first release, I'd appreciate guidance from someone.

Sorry for the late reply @ivanvc. I don't see any outstanding / missed issues or PRs so far! Thanks

ivanvc · 2024-09-04T23:41:23Z

We'll be doing the release after updating to the Go 1.22.7 release #18485 (comment).

ivanvc · 2024-09-09T23:29:14Z

Hi team (@ahrtr, @ahrtr), With v3.5.16 being released tomorrow, I wanted to check your availability to do the v3.4.34 release. Would this Wednesday at 11 a.m. PT/7 p.m. BST/8 p.m. CEST or Thursday at 10 a.m. PT/6 p.m. BST/7 p.m. CEST (before the etcd community/triage meeting) work for you?

ahrtr · 2024-09-10T09:10:15Z

Wednesday at 11 a.m. PT/7 p.m. BST

Works for me.

ivanvc · 2024-09-11T19:01:20Z

We just finished the release. We noted a couple of improvements to the documentation:

Update the release note for 3.4 specific instructions before step 6

Manually create the release tag

gpg --list-keys --with-colons "<[email protected]>" | awk -F: '/^pub:/ { print $5 }'
git tag --local-user "<GPG key from previous step>" --sign "v${VERSION}" --message "v${VERSION}"

Manually push the tag to GitHub git push origin ${VERSION}

In step 7, add a bullet to check the historic binary size for each arch. If there's a big difference, check if the binaries work
Before step 9, add a note on removing quay.io login from ~/.docker/config.json

ahrtr · 2024-09-11T19:16:02Z

We just finished the release. We noted a couple of improvements to the documentation:
Update the release note for 3.4 specific instructions before step 6
Manually create the release tag
gpg --list-keys --with-colons "<[email protected]>" | awk -F: '/^pub:/ { print $5 }'
git tag --local-user "<GPG key from previous step>" --sign "v${VERSION}" --message "v${VERSION}"
Manually push the tag to GitHub git push origin ${VERSION}
In step 7, add a bullet to check the historic binary size for each arch. If there's a big difference, check if the binaries work

Before step 9, add a note on removing quay.io login from ~/.docker/config.json

Also as James pointed out in the meeting, please feel free to review the release script and try to avoid the manual steps if possible.

The only reason why I manually executed the steps when I was releasing 3.4.x is that I was trying to reduce the risk as much as possible, because there was no one I could ask help for when I was releasing 3.4.x.

henrybear327 · 2024-09-11T19:19:54Z

We just finished the release. We noted a couple of improvements to the documentation:
Update the release note for 3.4 specific instructions before step 6
Manually create the release tag
gpg --list-keys --with-colons "<[email protected]>" | awk -F: '/^pub:/ { print $5 }'
git tag --local-user "<GPG key from previous step>" --sign "v${VERSION}" --message "v${VERSION}"
Manually push the tag to GitHub git push origin ${VERSION}
In step 7, add a bullet to check the historic binary size for each arch. If there's a big difference, check if the binaries work

Before step 9, add a note on removing quay.io login from ~/.docker/config.json

Also check for newlines when composing the announcement message!

ivanvc · 2024-09-12T17:28:00Z

Hi team, I was looking into implementing the tagging into 3.4's release script, but I found that the version bumping and tagging are already implemented. Refer to the following snippets, which are from the release-3.4 branch:

etcd/scripts/release.sh

Lines 93 to 107 in a1375b7

    
           # If the release tag does not already exist remotely, create it. 
        
           log_callout "Create tag if not present" 
        
           if [ "${remote_tag_exists}" -eq 0 ]; then 
        
             # Bump version/version.go to release version. 
        
             local source_version 
        
             source_version=$(grep -E "\s+Version\s*=" version/version.go | sed -e "s/.*\"\(.*\)\".*/\1/g") 
        
             if [[ "${source_version}" != "${VERSION}" ]]; then 
        
               source_minor_version=$(echo "${source_version}" | cut -d. -f 1-2) 
        
               if [[ "${source_minor_version}" != "${MINOR_VERSION}" ]]; then 
        
                 log_error "Wrong etcd minor version in version/version.go. Expected ${MINOR_VERSION} but got ${source_minor_version}. Aborting." 
        
                 exit 1 
        
               fi 
        
               echo "Updating version from ${source_version} to ${VERSION} in version/version.go" 
        
               sed -i "s/${source_version}/${VERSION}/g" version/version.go 
        
             fi

etcd/scripts/release.sh

Lines 133 to 145 in a1375b7

    
           # Tag release. 
        
           if [ "$(git tag --list | grep -c "${RELEASE_VERSION}")" -gt 0 ]; then 
        
             log_callout "Skipping tag step. git tag ${RELEASE_VERSION} already exists." 
        
           else 
        
             log_callout "Tagging release..." 
        
             gitemail=$(git config --get user.email) 
        
             KEYID=$(gpg --list-keys --with-colons "${gitemail}" | awk -F: '/^pub:/ { print $5 }') 
        
             if [[ -z "${KEYID}" ]]; then 
        
               log_error "Failed to load gpg key. Is gpg set up correctly for etcd releases?" 
        
               exit 1 
        
             fi 
        
             git tag --local-user "${KEYID}" --sign "${RELEASE_VERSION}" --message "${RELEASE_VERSION}" 
        
           fi

So, I don't think we need to make any changes to this.

ahrtr · 2024-09-12T18:07:55Z

So, I don't think we need to make any changes to this.

Right, but the script has never been verified/tested :)

ivanvc · 2024-09-12T18:31:28Z

Right, but the script has never been verified/tested :)

Do you think we should try at next's 3.4 release? Or, what would be a good way to test this?

jmhbnz · 2024-09-12T18:33:46Z

Do you think we should try at next's 3.4 release? Or, what would be a good way to test this?

I have a plan to safely verify this at the next 3.4 release. There are additional flags we can use in the script to test changes locally.

ivanvc · 2024-09-12T22:52:08Z

Ah, @jmhbnz, I didn't see your reply, so I was finding a way to test this. I managed to do it using my fork (https://github.com/ivanvc/etcd/tree/release-3.4) and passed the REPOSITORY variable set to my fork. I verified that it partially works:

It did update version/version.go, and pushed it to the remote (ivanvc@853b46f).
It did create the tag but didn't push it. After reviewing the script, I verified that it does not push the tag.

Is it okay if I implement pushing the tag, and we test it during the next v3.4 after I verify it works on my fork?

jmhbnz · 2024-09-13T05:53:02Z

Is it okay if I implement pushing the tag, and we test it during the next v3.4 after I verify it works on my fork?

Absolutely! - I would like to create some consistency between both stable release branches so that both work the same way with the same level of automation.

ivanvc · 2024-09-20T17:13:16Z

With all tasks completed, I'll go ahead and close this issue. Thanks, team, for helping with another successful v3.4 release 🎉

jcferretti · 2024-09-26T04:49:51Z

Do we want to merge its PR (#18268)?

NO, the PR changes the most important part of etcdserver, but without proper test cases. Since it's low priority/impact, we can revisit it in future when we have bandwidth.

There have been no responses on that PR for 2 months.
If you had mentioned anything about the existing tests and how it is that they are lacking or what you would actually want to see, I could have tried to do something about it.

ivanvc added the type/feature label Aug 22, 2024

ivanvc mentioned this issue Aug 22, 2024

Watch dropping an event when compacting on delete #18089

Closed

4 tasks

jmhbnz added the area/security label Aug 23, 2024

ivanvc mentioned this issue Sep 3, 2024

Plan to release etcd v3.5.16 #18485

Closed

2 tasks

ivanvc assigned ivanvc, henrybear327 and ahrtr Sep 4, 2024

jmhbnz added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 5, 2024

ivanvc mentioned this issue Sep 11, 2024

CHANGELOG: set release 3.4.34 date #18577

Merged

ivanvc mentioned this issue Sep 13, 2024

[3.4] release: push tag after creating it #18587

Merged

ivanvc mentioned this issue Sep 17, 2024

docs: update release.md with improvements from v3.4.34 release #18600

Merged

ivanvc closed this as completed Sep 20, 2024

jcferretti mentioned this issue Sep 26, 2024

Ensure Count in GET response is consistent with key filtering by revision #18268

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plan to release etcd v3.4.34 #18486

Plan to release etcd v3.4.34 #18486

ivanvc commented Aug 22, 2024 •

edited

Loading

serathius commented Sep 3, 2024 •

edited

Loading

ahrtr commented Sep 3, 2024

henrybear327 commented Sep 3, 2024

ivanvc commented Sep 3, 2024 •

edited

Loading

ivanvc commented Sep 4, 2024

ahrtr commented Sep 4, 2024

ahrtr commented Sep 4, 2024

henrybear327 commented Sep 4, 2024

ivanvc commented Sep 4, 2024 •

edited

Loading

ivanvc commented Sep 9, 2024

ahrtr commented Sep 10, 2024

ivanvc commented Sep 11, 2024 •

edited

Loading

ahrtr commented Sep 11, 2024 •

edited

Loading

henrybear327 commented Sep 11, 2024

ivanvc commented Sep 12, 2024

ahrtr commented Sep 12, 2024

ivanvc commented Sep 12, 2024

jmhbnz commented Sep 12, 2024

ivanvc commented Sep 12, 2024 •

edited

Loading

jmhbnz commented Sep 13, 2024

ivanvc commented Sep 20, 2024

jcferretti commented Sep 26, 2024

Plan to release etcd v3.4.34 #18486

Plan to release etcd v3.4.34 #18486

Comments

ivanvc commented Aug 22, 2024 • edited Loading

What would you like to be added?

The list of commits included since the previous release is: v3.4.33...release-3.4:

List of pull requests we still need to backport from main to release-3.4 before the patch release is issued:

Release team

Why is this needed?

serathius commented Sep 3, 2024 • edited Loading

ahrtr commented Sep 3, 2024

henrybear327 commented Sep 3, 2024

ivanvc commented Sep 3, 2024 • edited Loading

ivanvc commented Sep 4, 2024

ahrtr commented Sep 4, 2024

ahrtr commented Sep 4, 2024

henrybear327 commented Sep 4, 2024

ivanvc commented Sep 4, 2024 • edited Loading

ivanvc commented Sep 9, 2024

ahrtr commented Sep 10, 2024

ivanvc commented Sep 11, 2024 • edited Loading

ahrtr commented Sep 11, 2024 • edited Loading

henrybear327 commented Sep 11, 2024

ivanvc commented Sep 12, 2024

ahrtr commented Sep 12, 2024

ivanvc commented Sep 12, 2024

jmhbnz commented Sep 12, 2024

ivanvc commented Sep 12, 2024 • edited Loading

jmhbnz commented Sep 13, 2024

ivanvc commented Sep 20, 2024

jcferretti commented Sep 26, 2024

ivanvc commented Aug 22, 2024 •

edited

Loading

List of pull requests we still need to backport from `main` to `release-3.4` before the patch release is issued:

serathius commented Sep 3, 2024 •

edited

Loading

ivanvc commented Sep 3, 2024 •

edited

Loading

ivanvc commented Sep 4, 2024 •

edited

Loading

ivanvc commented Sep 11, 2024 •

edited

Loading

ahrtr commented Sep 11, 2024 •

edited

Loading

ivanvc commented Sep 12, 2024 •

edited

Loading