-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ert plugin mechanism to install forward models #75
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 87.79% 87.39% -0.40%
==========================================
Files 133 134 +1
Lines 3350 3356 +6
==========================================
- Hits 2941 2933 -8
- Misses 409 423 +14 ☔ View full report in Codecov by Sentry. |
61f5ec2
to
2ee51ed
Compare
2ee51ed
to
2f44d01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but maybe @yngve-sk should also take a look given he is a bit more familiar with ForwardModelStepPlugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a step in the right direction, removing all the config files. This is quite generic and in the long term we should explicitly type out one forward model per script (especially if we have validations that can be put there). But with all validations still packed inside the executables I suppose it has the same behavior as the old-style format.
2f44d01
to
ae1fb1a
Compare
def6dc9
to
acde21c
Compare
I think we should remove the everest plugin functionality in the long run. Since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolves equinor/ert#9147
This will break Everest, to be fixed by: equinor/ert#9148