-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ert plugin system for installing everest forward models #9148
base: main
Are you sure you want to change the base?
Conversation
3e16f7f
to
0a337c4
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
0a337c4
to
07f44e8
Compare
tests/everest/test_fm_plugins.py
Outdated
@@ -68,7 +67,7 @@ def get_forward_models(self): | |||
|
|||
pm = plugin_manager(Plugin1(), Plugin2()) | |||
|
|||
jobs = list(chain.from_iterable(pm.hook.get_forward_models())) | |||
jobs = set(chain.from_iterable(pm.hook.get_forward_models())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why set
instead of list
here? Did you get duplicate forward models showing up
@@ -64,8 +64,6 @@ def flow_config_path(): | |||
def get_forward_models(): | |||
""" | |||
Return a list of dicts detailing the names and paths to forward models. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this hook spec deprecated now? I see only the example doc was removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, only a few small questions. If this runs fine on the GHA workflow against your Everest models PR I'd say go for it
a94c504
to
78566f7
Compare
Issue
Closes #9147
Approach
Requires a PR in
everest-models
: equinor/everest-models#75(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable