Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ert and everest validation of forward models #8847

Open
oyvindeide opened this issue Oct 2, 2024 · 3 comments
Open

Align ert and everest validation of forward models #8847

oyvindeide opened this issue Oct 2, 2024 · 3 comments
Assignees

Comments

@oyvindeide
Copy link
Collaborator

oyvindeide commented Oct 2, 2024

Currently ert and everest have slightly different ways of validating the forward models, in everest there is an option for the forward model to supply their pydantic schema, which can be validated by everest:

job_schemas = collect_forward_model_schemas()
, while in ert, we have two optional functions which can be implemented to the forward model:
fm_step.validate_pre_experiment(job_json)
.

This might be an epic, in which case we should produce sub issues and track them in this issue.

The best approach is probably to modify the everest hooks to use the relatively new functionality in ert.

@DanSava DanSava added the everest label Oct 3, 2024
@frode-aarstad frode-aarstad self-assigned this Oct 28, 2024
@verveerpj verveerpj assigned verveerpj and unassigned frode-aarstad Oct 28, 2024
@verveerpj verveerpj changed the title Align ert and everest validation of forward models Align ert and everest installation and validation of forward models Oct 29, 2024
@verveerpj verveerpj added the epic label Oct 29, 2024
@verveerpj
Copy link
Contributor

To make use of the ERT validation code, it seems that forward models need to be added as preinstalled forward model steps. Everest uses currently the INSTALL_JOB keyword, hence the first step is to make everest-models use the plugin system to add its jobs to ERT.

@verveerpj
Copy link
Contributor

It turns out that the validation of the forward models requires knowledge of the data that Everest wants to install while running the steps of the forward model. This knowledge is available in the Everest configuration (install_data), but is lost when the ERT configuration is created. Since the ERT forward model classes don't have access to the Everest configuration, they cannot run the validation which requires access to installed files.

It seems therefore that validation of the forward models at the level of the Everest configuration is in fact appropriate, and should probably remain as is.

@verveerpj verveerpj changed the title Align ert and everest installation and validation of forward models Align ert and everest validation of forward models Nov 4, 2024
@verveerpj
Copy link
Contributor

Blocked by: #9145

@verveerpj verveerpj added blocked and removed epic labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants