-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align ert and everest validation of forward models #8847
Comments
To make use of the ERT validation code, it seems that forward models need to be added as preinstalled forward model steps. Everest uses currently the INSTALL_JOB keyword, hence the first step is to make |
It turns out that the validation of the forward models requires knowledge of the data that Everest wants to install while running the steps of the forward model. This knowledge is available in the Everest configuration ( It seems therefore that validation of the forward models at the level of the Everest configuration is in fact appropriate, and should probably remain as is. |
Blocked by: #9145 |
Currently ert and everest have slightly different ways of validating the forward models, in everest there is an option for the forward model to supply their pydantic schema, which can be validated by everest:
ert/src/everest/config/validation_utils.py
Line 284 in 398ce6a
ert/src/ert/config/ert_config.py
Line 603 in 9f8d73a
This might be an epic, in which case we should produce sub issues and track them in this issue.
The best approach is probably to modify the
everest
hooks to use the relatively new functionality in ert.The text was updated successfully, but these errors were encountered: