Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare new Dockerfile for K8s Compatibility #1092

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

ryan-mcneil
Copy link
Contributor

@ryan-mcneil ryan-mcneil commented Apr 10, 2024

Description

  • This PR introduces what will some day replace the current Dockerfile and associated files.
  • The new Dockerfile is based on the template/boilerplate Dockerfile provided with new Rails apps (specifically 7.1.3)

This Dockerfile/Docker Compose file are development ready. To run locally, you can specify the "new" dockerfile:
docker compose -f docker-compose-new.yml up, and append the flag --build to the end of the command to pick up any changes to the image.

Original issue(s)

department-of-veterans-affairs/va.gov-team#79340

Testing done

  • Image successfully builds and listens on localhost:3000
  • Specs can be run in container

Screenshots

Acceptance criteria

  • [ ]

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@ryan-mcneil ryan-mcneil changed the title Prepare new Dockerfile for development Prepare new Dockerfile for K8s Compatibility Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant