-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTSAM_DT_MERGING Flag #1501
Merged
Merged
GTSAM_DT_MERGING Flag #1501
Changes from 2 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
e114e9f
add nrAssignments method for DecisionTree
varunagrawal 6aa7d66
add unit test showing issue with nrAssignments
varunagrawal 1818695
updated docs to better describe nrAssignments
varunagrawal 0cd36db
Merge branch 'develop' into fix-1496
varunagrawal 73b563a
WIP for debugging nrAssignments issue
varunagrawal 8a8f146
update Unique to be recursive
varunagrawal ff1ea32
remove unnecessary code
varunagrawal dbd0a7d
re-enable DecisionTree tests
varunagrawal 68cb724
add new build method to replace create, and let create call Unique
varunagrawal be70ffc
remove excessive Unique call to improve efficiency
varunagrawal c3090f0
cleanup
varunagrawal 70ffbf3
mark nrAssignments as const
varunagrawal 2352043
rename GTSAM_DT_NO_PRUNING to GTSAM_DT_NO_MERGING to help with disamb…
varunagrawal 2998820
bottom-up Unique method that works much, much better
varunagrawal a66e270
print nrAssignments when printing decision trees
varunagrawal d74e41a
Merge branch 'develop' into decisiontree-improvements
varunagrawal 39cf348
Merge branch 'develop' into fix-1496
varunagrawal 0cb1316
Merge branch 'fix-1496' into decisiontree-improvements
varunagrawal 76568f2
formatting
varunagrawal 29c1816
change to GTSAM_DT_MERGING and expose via CMake
varunagrawal 8959982
remove extra calls to Unique
varunagrawal 88ab371
Merge branch 'develop' into decisiontree-improvements
varunagrawal 7af8e66
Merge branch 'develop' into decisiontree-improvements
varunagrawal c605a5b
Merge branch 'develop' into fix-1496
varunagrawal b37fc3f
update DecisionTree::nrAssignments docstring
varunagrawal 3d7163a
Merge branch 'fix-1496' into decisiontree-improvements
varunagrawal b24f20a
fix tests to work when GTSAM_DT_MERGING=OFF
varunagrawal 8ffddc4
print GTSAM_DT_MERGING cmake config
varunagrawal e5fea0d
update docstring
varunagrawal 9b7f4b3
fix test case
varunagrawal 8c38e45
enumerate all assignments for computing probabilities to prune
varunagrawal b86696a
Merge pull request #1542 from borglab/decisiontree-improvements
varunagrawal 647d3c0
remove nrAssignments from the DecisionTree
varunagrawal 2db0828
Revert "remove nrAssignments from the DecisionTree"
varunagrawal b7deefd
Revert "enumerate all assignments for computing probabilities to prune"
varunagrawal e5a7bac
Merge pull request #1555 from borglab/remove-nrAssignments
varunagrawal 3fe9f1a
Merge branch 'develop' into fix-1496
varunagrawal ff7c368
Merge branch 'hybrid-tablefactor-2' into fix-1496
varunagrawal cf6c1ca
fix tests
varunagrawal 372e703
Merge branch 'develop' into fix-1496
varunagrawal 1dfb388
fix odd behavior in nrAssignments
varunagrawal ea24a2c
park changes so I can come back to them later
varunagrawal 369d08b
Merge branch 'develop' into fix-1496
varunagrawal b35fb0f
update tests
varunagrawal 4e9d849
remove prints
varunagrawal 4580c51
undo change
varunagrawal 8cb33dd
remove make_unique flag
varunagrawal 94d737e
remove printing
varunagrawal 4386c51
remove nrAssignments from DecisionTree
varunagrawal ecd6450
Merge branch 'develop' into fix-1496
varunagrawal c4d11c4
fix unittest assertion deprecation
varunagrawal 9b67c3a
Merge branch 'develop' into remove-nrAssignments
varunagrawal fe81362
Merge branch 'fix-1496' into remove-nrAssignments
varunagrawal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give examples as to what this is, I think "number of assignments" needs to be explained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO(Frank): Add comments to mention that this is a convenience function and not used for any major operation.