Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTSAM_DT_MERGING Flag #1501

Merged
merged 53 commits into from
Nov 11, 2023
Merged

GTSAM_DT_MERGING Flag #1501

merged 53 commits into from
Nov 11, 2023

Commits on Mar 26, 2023

  1. add nrAssignments method for DecisionTree

    @varunagrawal
    varunagrawal committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    e114e9f View commit details
    Browse the repository at this point in the history

  2. add unit test showing issue with nrAssignments

    @varunagrawal
    varunagrawal committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    6aa7d66 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. updated docs to better describe nrAssignments

    @varunagrawal
    varunagrawal committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    1818695 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge branch 'develop' into fix-1496

    @varunagrawal
    varunagrawal committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    0cd36db View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. WIP for debugging nrAssignments issue

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    73b563a View commit details
    Browse the repository at this point in the history

  2. update Unique to be recursive

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    8a8f146 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary code

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    ff1ea32 View commit details
    Browse the repository at this point in the history

  4. re-enable DecisionTree tests

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    dbd0a7d View commit details
    Browse the repository at this point in the history

  5. add new build method to replace create, and let create call Unique

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    68cb724 View commit details
    Browse the repository at this point in the history

  6. remove excessive Unique call to improve efficiency

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    be70ffc View commit details
    Browse the repository at this point in the history

  7. cleanup

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    c3090f0 View commit details
    Browse the repository at this point in the history

  8. mark nrAssignments as const

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    70ffbf3 View commit details
    Browse the repository at this point in the history

  9. rename GTSAM_DT_NO_PRUNING to GTSAM_DT_NO_MERGING to help with disamb… 

    …iguation
    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    2352043 View commit details
    Browse the repository at this point in the history

  10. bottom-up Unique method that works much, much better

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    2998820 View commit details
    Browse the repository at this point in the history

  11. print nrAssignments when printing decision trees

    @varunagrawal
    varunagrawal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a66e270 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'develop' into decisiontree-improvements

    @varunagrawal
    varunagrawal committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d74e41a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix-1496

    @varunagrawal
    varunagrawal committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    39cf348 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-1496' into decisiontree-improvements

    @varunagrawal
    varunagrawal committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    0cb1316 View commit details
    Browse the repository at this point in the history

  4. formatting

    @varunagrawal
    varunagrawal committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    76568f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. change to GTSAM_DT_MERGING and expose via CMake

    @varunagrawal
    varunagrawal committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    29c1816 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. remove extra calls to Unique

    @varunagrawal
    varunagrawal committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    8959982 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Merge branch 'develop' into decisiontree-improvements

    @varunagrawal
    varunagrawal committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    88ab371 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into decisiontree-improvements

    @varunagrawal
    varunagrawal committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7af8e66 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Merge branch 'develop' into fix-1496

    @varunagrawal
    varunagrawal committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c605a5b View commit details
    Browse the repository at this point in the history

  2. update DecisionTree::nrAssignments docstring

    @varunagrawal
    varunagrawal committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    b37fc3f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-1496' into decisiontree-improvements

    @varunagrawal
    varunagrawal committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    3d7163a View commit details
    Browse the repository at this point in the history

  4. fix tests to work when GTSAM_DT_MERGING=OFF

    @varunagrawal
    varunagrawal committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    b24f20a View commit details
    Browse the repository at this point in the history

  5. print GTSAM_DT_MERGING cmake config

    @varunagrawal
    varunagrawal committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8ffddc4 View commit details
    Browse the repository at this point in the history

  6. update docstring

    @varunagrawal
    varunagrawal committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e5fea0d View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. fix test case

    @varunagrawal
    varunagrawal committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    9b7f4b3 View commit details
    Browse the repository at this point in the history

  2. enumerate all assignments for computing probabilities to prune

    @varunagrawal
    varunagrawal committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8c38e45 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1542 from borglab/decisiontree-improvements

    @varunagrawal
    varunagrawal authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b86696a View commit details
    Browse the repository at this point in the history

  4. remove nrAssignments from the DecisionTree

    @varunagrawal
    varunagrawal committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    647d3c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Revert "remove nrAssignments from the DecisionTree" 

    This reverts commit 647d3c0.
    @varunagrawal
    varunagrawal committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    2db0828 View commit details
    Browse the repository at this point in the history

  2. Revert "enumerate all assignments for computing probabilities to prune" 

    This reverts commit 8c38e45.
    @varunagrawal
    varunagrawal committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b7deefd View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1555 from borglab/remove-nrAssignments

    @varunagrawal
    varunagrawal authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    e5a7bac View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge branch 'develop' into fix-1496

    @varunagrawal
    varunagrawal committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    3fe9f1a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge branch 'hybrid-tablefactor-2' into fix-1496

    @varunagrawal
    varunagrawal committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ff7c368 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @varunagrawal
    varunagrawal committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    cf6c1ca View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into fix-1496

    @varunagrawal
    varunagrawal committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    372e703 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. fix odd behavior in nrAssignments

    @varunagrawal
    varunagrawal committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1dfb388 View commit details
    Browse the repository at this point in the history

  2. park changes so I can come back to them later

    @varunagrawal
    varunagrawal committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ea24a2c View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Merge branch 'develop' into fix-1496

    @varunagrawal
    varunagrawal committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    369d08b View commit details
    Browse the repository at this point in the history

  2. update tests

    @varunagrawal
    varunagrawal committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b35fb0f View commit details
    Browse the repository at this point in the history

  3. remove prints

    @varunagrawal
    varunagrawal committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    4e9d849 View commit details
    Browse the repository at this point in the history

  4. undo change

    @varunagrawal
    varunagrawal committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    4580c51 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. remove make_unique flag

    @varunagrawal
    varunagrawal committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    8cb33dd View commit details
    Browse the repository at this point in the history

  2. remove printing

    @varunagrawal
    varunagrawal committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    94d737e View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. remove nrAssignments from DecisionTree

    @varunagrawal
    varunagrawal committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    4386c51 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix-1496

    @varunagrawal
    varunagrawal committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    ecd6450 View commit details
    Browse the repository at this point in the history

  3. fix unittest assertion deprecation

    @varunagrawal
    varunagrawal committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    c4d11c4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into remove-nrAssignments

    @varunagrawal
    varunagrawal committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    9b67c3a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix-1496' into remove-nrAssignments

    @varunagrawal
    varunagrawal committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    fe81362 View commit details
    Browse the repository at this point in the history