Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_control_validator): fix clang-diagnostic-unused-private-field #9381

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Nov 19, 2024

Description

Removed unnecessary is_velocity_valid_ variable.

This solves the following clang-tidy error

autoware/src/universe/autoware.universe/control/autoware_control_validator/include/autoware/control_validator/control_validator.hpp:152:8: error: private field 'is_velocity_valid_' is not used [clang-diagnostic-unused-private-field]
  bool is_velocity_valid_{true};
       ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@veqcc veqcc self-assigned this Nov 19, 2024
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Nov 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.78%. Comparing base (a0c4ab4) to head (580dbb5).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9381      +/-   ##
==========================================
- Coverage   29.79%   29.78%   -0.01%     
==========================================
  Files        1338     1339       +1     
  Lines      103211   103229      +18     
  Branches    40212    40213       +1     
==========================================
  Hits        30748    30748              
- Misses      69477    69495      +18     
  Partials     2986     2986              
Flag Coverage Δ *Carryforward flag
differential 5.67% <ø> (?)
total 29.79% <ø> (ø) Carriedforward from a0c4ab4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.LGTM

@veqcc veqcc merged commit 332a9bb into autowarefoundation:main Nov 19, 2024
42 checks passed
@veqcc veqcc deleted the fix/remove_unnecessary branch November 19, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants