Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(perception_utils): install include directory #9354

Merged

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 18, 2024

Description

This PR changes to install perception_utils's include directory to solve the following problem.

https://github.com/autowarefoundation/autoware/actions/runs/11883993784/job/33111547398?pr=5446#step:5:16248

#94 80.89 --- stderr: autoware_tensorrt_yolox
#94 80.89 /autoware/src/universe/autoware.universe/perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp:18:10: fatal error: perception_utils/run_length_encoder.hpp: No such file or directory
#94 80.89    18 | #include "perception_utils/run_length_encoder.hpp"
#94 80.89       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#94 80.89 compilation terminated.
#94 80.89 gmake[2]: *** [CMakeFiles/autoware_tensorrt_yolox_node.dir/build.make:76: CMakeFiles/autoware_tensorrt_yolox_node.dir/src/tensorrt_yolox_node.cpp.o] Error 1
#94 80.89 gmake[1]: *** [CMakeFiles/Makefile2:254: CMakeFiles/autoware_tensorrt_yolox_node.dir/all] Error 2
#94 80.89 gmake: *** [Makefile:146: all] Error 2
#94 80.89 ---
#94 80.89 Failed   <<< autoware_tensorrt_yolox [1min 15s, exited with code 2]

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@youtalk youtalk self-assigned this Nov 18, 2024
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk marked this pull request as ready for review November 18, 2024 07:37
@youtalk youtalk added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.81%. Comparing base (4a4db99) to head (8ede12d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9354   +/-   ##
=======================================
  Coverage   29.80%   29.81%           
=======================================
  Files        1338     1338           
  Lines      103252   103253    +1     
  Branches    40238    40241    +3     
=======================================
+ Hits        30777    30784    +7     
+ Misses      69487    69482    -5     
+ Partials     2988     2987    -1     
Flag Coverage Δ *Carryforward flag
differential 3.99% <ø> (?)
total 29.81% <ø> (+<0.01%) ⬆️ Carriedforward from 4a4db99

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@youtalk
Copy link
Member Author

youtalk commented Nov 18, 2024

@miursh @YoshiRi Please review this. It has no side effect.

@youtalk youtalk enabled auto-merge (squash) November 18, 2024 23:32
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit 9aab36b into autowarefoundation:main Nov 19, 2024
44 checks passed
@youtalk youtalk deleted the install-perception-utils-include branch November 19, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Development

Successfully merging this pull request may close these issues.

2 participants