Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): remove use_object_recognition because it is default #10050

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 30, 2025

Description

depends: #10049

launcher PR: autowarefoundation/autoware_launch#1318

Related links

https://tier4.atlassian.net/browse/RT1-6895

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

mergify bot commented Jan 30, 2025

⚠️ The sha of the head commit of this PR conflicts with #10049. Mergify cannot evaluate rules on this PR. ⚠️

@soblin soblin force-pushed the refactor/goal-planner/remove-use-object-recognition branch 4 times, most recently from 0ff2b18 to e0d59ec Compare January 31, 2025 00:14
@soblin soblin force-pushed the refactor/goal-planner/remove-use-object-recognition branch from e0d59ec to 9d29658 Compare January 31, 2025 00:52
@soblin soblin marked this pull request as ready for review January 31, 2025 01:36
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 28.86%. Comparing base (d63bec2) to head (9d29658).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 59 Missing ⚠️
...or_path_goal_planner_module/src/decision_state.cpp 0.00% 3 Missing ⚠️
...ior_path_goal_planner_module/src/goal_searcher.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10050      +/-   ##
==========================================
+ Coverage   28.29%   28.86%   +0.56%     
==========================================
  Files        1484     1446      -38     
  Lines      111101   109063    -2038     
  Branches    43170    43144      -26     
==========================================
+ Hits        31441    31477      +36     
+ Misses      76641    74497    -2144     
- Partials     3019     3089      +70     
Flag Coverage Δ *Carryforward flag
differential 0.50% <0.00%> (?)
total 29.17% <ø> (+0.87%) ⬆️ Carriedforward from d63bec2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 74f4390 into autowarefoundation:main Jan 31, 2025
45 of 46 checks passed
@soblin soblin deleted the refactor/goal-planner/remove-use-object-recognition branch January 31, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants