Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 38 password keyboard behaviour #43

Merged
merged 30 commits into from
Jun 22, 2024

refactored register button enabled form validation into view model

0af5247
Select commit
Loading
Failed to load commit list.
Merged

Fix/issue 38 password keyboard behaviour #43

refactored register button enabled form validation into view model
0af5247
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 22, 2024 in 1s

27.54% (+1.58%) compared to 1f3a66f

View this Pull Request on Codecov

27.54% (+1.58%) compared to 1f3a66f

Details

Codecov Report

Attention: Patch coverage is 15.61644% with 308 lines in your changes missing coverage. Please review.

Project coverage is 27.54%. Comparing base (1f3a66f) to head (0af5247).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #43      +/-   ##
============================================
+ Coverage     25.97%   27.54%   +1.58%     
- Complexity      195      228      +33     
============================================
  Files           102      105       +3     
  Lines          2916     3102     +186     
  Branches        403      439      +36     
============================================
+ Hits            757      854      +97     
- Misses         2122     2196      +74     
- Partials         37       52      +15     
Files Coverage Δ
...edu/stanford/spezi/module/account/login/UiState.kt 100.00% <100.00%> (+100.00%) ⬆️
...d/spezi/module/account/login/LoginFormValidator.kt 66.67% <66.67%> (ø)
...ord/spezi/module/account/register/FormValidator.kt 90.00% <90.00%> (ø)
...d/spezi/module/account/register/RegisterUiState.kt 93.11% <80.00%> (-2.72%) ⬇️
...n/kotlin/edu/stanford/bdh/engagehf/MainActivity.kt 0.00% <0.00%> (ø)
...account/cred/manager/CredentialLoginManagerAuth.kt 2.57% <0.00%> (+2.57%) ⬆️
...i/module/account/register/RegisterFormValidator.kt 21.74% <7.15%> (-14.26%) ⬇️
...ed/outlinedtextfield/ValidatedOutlinedTextField.kt 0.00% <0.00%> (ø)
...spezi/module/account/register/RegisterViewModel.kt 28.04% <45.17%> (+5.42%) ⬆️
...nford/spezi/module/account/login/LoginViewModel.kt 40.00% <41.82%> (+40.00%) ⬆️
... and 3 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3a66f...0af5247. Read the comment docs.