Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/issue 38 password keyboard behaviour #43

Merged
merged 30 commits into from
Jun 22, 2024
Merged

Fix/issue 38 password keyboard behaviour #43

merged 30 commits into from
Jun 22, 2024

Commits on Jun 14, 2024

  1. extended ValidatedOutlinedTextField 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    437e81e View commit details
    Browse the repository at this point in the history

  2. updated RegisterScreen to ValidatedOutlinedTextField 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ca1ab36 View commit details
    Browse the repository at this point in the history

  3. added visibility icon on/off 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a7fa86e View commit details
    Browse the repository at this point in the history

  4. added LoginFormValidator 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    445f308 View commit details
    Browse the repository at this point in the history

  5. update password keyboard Behaviour in LoginScreen 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0e0a64c View commit details
    Browse the repository at this point in the history

  6. tested CredentialRegisterManagerAuth 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9b14a16 View commit details
    Browse the repository at this point in the history

  7. update RegisterFormValidatorTest 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d11b89a View commit details
    Browse the repository at this point in the history

  8. tested LoginViewModel 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    93c97d9 View commit details
    Browse the repository at this point in the history

  9. switched to PattersCompat Email Matcher for easier testing 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    18e6dc8 View commit details
    Browse the repository at this point in the history

  10. tested LoginFormValidator 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    decf4e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Fix/issue 32 leading aligned icons register (#44) 

    # *Fix/issue 32 leading aligned icons register*

Could be either merged into #43 or main once #43 is merged

## ♻️ Current situation & Problem
#32 


## ⚙️ Release Notes 

- IconLeadingContent Composable
- Adapted RegisterScreen accordingly


## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).

---------

Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c170066 View commit details
    Browse the repository at this point in the history

  2. vertical aligned leading icon to top 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    bab77f2 View commit details
    Browse the repository at this point in the history

  3. invoked painter resource on iconId 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    475d254 View commit details
    Browse the repository at this point in the history

  4. added local date format and also moved formatting into view model 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9217d44 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix/issue-38-password-keyboard-behaviour

    @Basler182
    Basler182 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d0cee71 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix/issue-38-password-keyboard-behaviour

    @Basler182
    Basler182 authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    40cf3f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. used typealias composable block 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f02427b View commit details
    Browse the repository at this point in the history

  2. improved FormValidator 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c4f0444 View commit details
    Browse the repository at this point in the history

  3. introduced namespace and extracted button enabled logic 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2383523 View commit details
    Browse the repository at this point in the history

  4. use run catching in password login 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    0d8a594 View commit details
    Browse the repository at this point in the history

  5. extracted date time formatter 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    bc02edf View commit details
    Browse the repository at this point in the history

  6. extracted register button enabled logic from screen 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2505669 View commit details
    Browse the repository at this point in the history

  7. extracted register button enabled logic from screen 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4bc3c48 View commit details
    Browse the repository at this point in the history

  8. added missing spacing 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    1c39df8 View commit details
    Browse the repository at this point in the history

  9. Removed enclosing update 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b1e0f2c View commit details
    Browse the repository at this point in the history

  10. updated tests 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    90c0a0d View commit details
    Browse the repository at this point in the history

  11. added password sign in enabled button 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4531c13 View commit details
    Browse the repository at this point in the history

  12. updated usage of .isValid 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f33201e View commit details
    Browse the repository at this point in the history

  13. changed property method order 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    175955c View commit details
    Browse the repository at this point in the history

  14. refactored register button enabled form validation into view model 

    Signed-off-by: Basler182 <[email protected]>
    @Basler182
    Basler182 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    0af5247 View commit details
    Browse the repository at this point in the history