Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 38 password keyboard behaviour #43

Merged
merged 30 commits into from
Jun 22, 2024

Conversation

Basler182
Copy link
Contributor

@Basler182 Basler182 commented Jun 14, 2024

Fix/issue 38 password keyboard behaviour

♻️ Current situation & Problem

#38

⚙️ Release Notes

  • Added Password Toogle Icon to Login Screen
  • Added Login Form Validator
  • Added Login Error Cases
  • Switched to OutlinedTextFields

✅ Testing

  • Added CredentialRegisterManagerAuthTest
  • Added LoginViewModelTest
  • Added LoginFormValidatorTest

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Basler182 Basler182 added the enhancement New feature or request label Jun 14, 2024
@Basler182 Basler182 self-assigned this Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 15.61644% with 308 lines in your changes missing coverage. Please review.

Project coverage is 27.54%. Comparing base (1f3a66f) to head (0af5247).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #43      +/-   ##
============================================
+ Coverage     25.97%   27.54%   +1.58%     
- Complexity      195      228      +33     
============================================
  Files           102      105       +3     
  Lines          2916     3102     +186     
  Branches        403      439      +36     
============================================
+ Hits            757      854      +97     
- Misses         2122     2196      +74     
- Partials         37       52      +15     
Flag Coverage Δ
unittests 27.54% <15.62%> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...edu/stanford/spezi/module/account/login/UiState.kt 100.00% <100.00%> (+100.00%) ⬆️
...d/spezi/module/account/login/LoginFormValidator.kt 66.67% <66.67%> (ø)
...ord/spezi/module/account/register/FormValidator.kt 90.00% <90.00%> (ø)
...d/spezi/module/account/register/RegisterUiState.kt 93.11% <80.00%> (-2.72%) ⬇️
...n/kotlin/edu/stanford/bdh/engagehf/MainActivity.kt 0.00% <0.00%> (ø)
...account/cred/manager/CredentialLoginManagerAuth.kt 2.57% <0.00%> (+2.57%) ⬆️
...i/module/account/register/RegisterFormValidator.kt 21.74% <7.15%> (-14.26%) ⬇️
...ed/outlinedtextfield/ValidatedOutlinedTextField.kt 0.00% <0.00%> (ø)
...spezi/module/account/register/RegisterViewModel.kt 28.04% <45.17%> (+5.42%) ⬆️
...nford/spezi/module/account/login/LoginViewModel.kt 40.00% <41.82%> (+40.00%) ⬆️
... and 3 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3a66f...0af5247. Read the comment docs.

@Basler182 Basler182 enabled auto-merge (squash) June 14, 2024 17:10
@Basler182 Basler182 disabled auto-merge June 14, 2024 17:10
@Basler182 Basler182 enabled auto-merge (squash) June 14, 2024 17:11
@PSchmiedmayer
Copy link
Member

Thank you for taking a look at this and fixing the issues in smaller targeted PRs @Basler182 🚀
I will defer to @eldcn or @pauljohanneskraft for an in-depth review of the changes.

Basler182 and others added 6 commits June 21, 2024 09:25
# *Fix/issue 32 leading aligned icons register*

Could be either merged into #43 or main once #43 is merged

## ♻️ Current situation & Problem
#32 


## ⚙️ Release Notes 

- IconLeadingContent Composable
- Adapted RegisterScreen accordingly


## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).

---------

Signed-off-by: Basler182 <[email protected]>
Copy link
Contributor

@eldcn eldcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Let's set as a goal for future PRs to have as less codecov complains comments for untested lines as possible 😄

@Basler182 Basler182 merged commit 9c33498 into main Jun 22, 2024
7 checks passed
@Basler182 Basler182 deleted the fix/issue-38-password-keyboard-behaviour branch June 22, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants