Add Clone for dmabuf feedback structs #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DmabufHandler::dmabuf_feedback` handler provides access to DMA buffer feedback, however working with this feedback becomes difficult when it needs to be stored in multiple places due to missing derives. So this patch adds the automatic `Clone` derive so the existing types in SCTK can be reused downstream. The `DmabufFeedback` itself does not implement `Clones` since it relies on the `Mmap` type, which is not cloneable.
chrisduerr
force-pushed
the
feedback_derives
branch
from
2d45848
to
c1312a6
Compare
PolyMeilex
approved these changes
Oct 16, 2024
|
Sounds like a good idea, sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DmabufHandler::dmabuf_feedbackhandler provides access to DMA buffer feedback, however working with this feedback becomes difficult when it needs to be stored in multiple places due to missing derives.So this patch adds the automatic
Clonederive so the existing types in SCTK can be reused downstream.The
DmabufFeedbackitself does not implementClonessince it relies on theMmaptype, which is not cloneable.Note I didn't actually require this myself since I was able to clone the WebKit type I used it for. But it seems useful for other people so I thought I might as well put up a PR.