Skip to content

Commit

Permalink
Merge pull request #467 from chrisduerr/feedback_derives
Browse files Browse the repository at this point in the history
Add Clone for dmabuf feedback structs
  • Loading branch information
PolyMeilex authored Oct 16, 2024
2 parents 37c55f4 + c1312a6 commit 828c2c3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
3 changes: 2 additions & 1 deletion src/dmabuf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type dev_t = u64;
use libc::dev_t;

/// A preference tranche of dmabuf formats
#[derive(Debug)]
#[derive(Clone, Debug)]
pub struct DmabufFeedbackTranche {
/// `dev_t` value for preferred target device. May be scan-out or
/// renderer device.
Expand All @@ -43,6 +43,7 @@ impl Default for DmabufFeedbackTranche {
/// A single dmabuf format/modifier pair
// Must have correct representation to be able to mmap format table
#[repr(C)]
#[derive(Copy, Clone)]
pub struct DmabufFormat {
/// Fourcc format
pub format: u32,
Expand Down
12 changes: 6 additions & 6 deletions src/globals.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ use wayland_client::Proxy;
/// argument. For example:
///
/// - A global that binds to `wl_compositor` with maximum version 4 could implement
/// `ProvidesBoundGlobal<WlCompositor, 4>`, `ProvidesBoundGlobal<WlCompositor, 3>`,
/// `ProvidesBoundGlobal<WlCompositor, 2>`, and `ProvidesBoundGlobal<WlCompositor, 1>` because
/// versions 2-4 only add additional requests to the `wl_surface` API.
/// `ProvidesBoundGlobal<WlCompositor, 4>`, `ProvidesBoundGlobal<WlCompositor, 3>`,
/// `ProvidesBoundGlobal<WlCompositor, 2>`, and `ProvidesBoundGlobal<WlCompositor, 1>` because
/// versions 2-4 only add additional requests to the `wl_surface` API.
/// - A global that binds to `wl_compositor` with maximum version 5 may only implement
/// `ProvidesBoundGlobal<WlCompositor, 5>` because version 5 makes using `wl_surface::attach` with
/// a nonzero offset a protocol error. A caller who is only aware of the version 4 API risks
/// causing these protocol errors if it uses surfaces created by such a global.
/// `ProvidesBoundGlobal<WlCompositor, 5>` because version 5 makes using `wl_surface::attach` with
/// a nonzero offset a protocol error. A caller who is only aware of the version 4 API risks
/// causing these protocol errors if it uses surfaces created by such a global.
///
/// Changes that cause compatibility breaks include:
///
Expand Down

0 comments on commit 828c2c3

Please sign in to comment.