Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clone for dmabuf feedback structs #467

Merged
merged 2 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/dmabuf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type dev_t = u64;
use libc::dev_t;

/// A preference tranche of dmabuf formats
#[derive(Debug)]
#[derive(Clone, Debug)]
pub struct DmabufFeedbackTranche {
/// `dev_t` value for preferred target device. May be scan-out or
/// renderer device.
Expand All @@ -43,6 +43,7 @@ impl Default for DmabufFeedbackTranche {
/// A single dmabuf format/modifier pair
// Must have correct representation to be able to mmap format table
#[repr(C)]
#[derive(Copy, Clone)]
pub struct DmabufFormat {
/// Fourcc format
pub format: u32,
Expand Down
12 changes: 6 additions & 6 deletions src/globals.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ use wayland_client::Proxy;
/// argument. For example:
///
/// - A global that binds to `wl_compositor` with maximum version 4 could implement
/// `ProvidesBoundGlobal<WlCompositor, 4>`, `ProvidesBoundGlobal<WlCompositor, 3>`,
/// `ProvidesBoundGlobal<WlCompositor, 2>`, and `ProvidesBoundGlobal<WlCompositor, 1>` because
/// versions 2-4 only add additional requests to the `wl_surface` API.
/// `ProvidesBoundGlobal<WlCompositor, 4>`, `ProvidesBoundGlobal<WlCompositor, 3>`,
/// `ProvidesBoundGlobal<WlCompositor, 2>`, and `ProvidesBoundGlobal<WlCompositor, 1>` because
/// versions 2-4 only add additional requests to the `wl_surface` API.
/// - A global that binds to `wl_compositor` with maximum version 5 may only implement
/// `ProvidesBoundGlobal<WlCompositor, 5>` because version 5 makes using `wl_surface::attach` with
/// a nonzero offset a protocol error. A caller who is only aware of the version 4 API risks
/// causing these protocol errors if it uses surfaces created by such a global.
/// `ProvidesBoundGlobal<WlCompositor, 5>` because version 5 makes using `wl_surface::attach` with
/// a nonzero offset a protocol error. A caller who is only aware of the version 4 API risks
/// causing these protocol errors if it uses surfaces created by such a global.
///
/// Changes that cause compatibility breaks include:
///
Expand Down
Loading