Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor project path resolvers in CohortExtractor #1957

Merged
merged 18 commits into from
Oct 10, 2024

use nameof instead of strings

7f6d1ae
Select commit
Loading
Failed to load commit list.
Merged

Refactor project path resolvers in CohortExtractor #1957

use nameof instead of strings
7f6d1ae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 10, 2024 in 0s

64.81% (-0.01%) compared to f547cf4

View this Pull Request on Codecov

64.81% (-0.01%) compared to f547cf4

Details

Codecov Report

Attention: Patch coverage is 82.60870% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.81%. Comparing base (f547cf4) to head (7f6d1ae).

Files with missing lines Patch % Lines
...ProjectPathResolvers/ProjectPathResolverFactory.cs 42.85% 3 Missing and 1 partial ⚠️
...ohortExtractor/RequestFulfillers/QueryToExecute.cs 66.66% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
- Coverage   64.82%   64.81%   -0.01%     
==========================================
  Files         181      183       +2     
  Lines        6538     6554      +16     
  Branches      963      963              
==========================================
+ Hits         4238     4248      +10     
- Misses       2017     2020       +3     
- Partials      283      286       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov