Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor project path resolvers in CohortExtractor #1957

Merged
merged 18 commits into from
Oct 10, 2024
Merged

Refactor project path resolvers in CohortExtractor #1957

merged 18 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. rename DefaultProjectPathResolver to StudySeriesOriginalFilenameProje… 

    …ctPathResolver
    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8b0e9d2 View commit details
    Browse the repository at this point in the history

  2. revert hidden directory handling (#1506)

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    95687e3 View commit details
    Browse the repository at this point in the history

  3. rename test file to match src

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    753bff7 View commit details
    Browse the repository at this point in the history

  4. add IFileSystem and extract constants

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8df5e7e View commit details
    Browse the repository at this point in the history

  5. add StudySeriesSOPProjectPathResolver

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    489d9cd View commit details
    Browse the repository at this point in the history

  6. disallow null Study/SeriesInstanceUIDs in extractions

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c52ea60 View commit details
    Browse the repository at this point in the history

  7. add fileSystem param to CohortExtractorHost

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0f307b4 View commit details
    Browse the repository at this point in the history

  8. fixup NoSuffixProjectPathResolver

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1e8ea62 View commit details
    Browse the repository at this point in the history

  9. disallow null Study/Series/SOPInstanceUIDs in CohortExtractor and fix… 

    …up tests
    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f166860 View commit details
    Browse the repository at this point in the history

  10. add tests for StudySeriesSOPProjectPathResolver

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4739ab4 View commit details
    Browse the repository at this point in the history

  11. make StudySeriesSOPProjectPathResolver the default in CohortExtractor

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    23e71c6 View commit details
    Browse the repository at this point in the history

  12. add news file

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0851349 View commit details
    Browse the repository at this point in the history

  13. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @rkm
    pre-commit-ci[bot] authored and rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6ec6759 View commit details
    Browse the repository at this point in the history

  14. update defaults in configs

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ed725f2 View commit details
    Browse the repository at this point in the history

  15. delete obsolete tests, as extraction must have all UIDs now

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a398a38 View commit details
    Browse the repository at this point in the history

  16. set MessageHeader.CurrentProgramName at test fixture level

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3bdb69c View commit details
    Browse the repository at this point in the history

  17. remove opaque ObjectFactory nonsense in favour of ProjectPathResolver… 

    …Factory
    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    18cc004 View commit details
    Browse the repository at this point in the history

  18. use nameof instead of strings

    @rkm
    rkm committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7f6d1ae View commit details
    Browse the repository at this point in the history