-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor project path resolvers in CohortExtractor #1957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkm
changed the title
Feature/path resolvers
Refactor project path resolvers in CohortExtractor
Oct 4, 2024
rkm
force-pushed
the
feature/path-resolvers
branch
from
October 7, 2024 10:36
eecafb4
to
a948edb
Compare
jas88
reviewed
Oct 7, 2024
...SmiServices/Microservices/CohortExtractor/ProjectPathResolvers/ProjectPathResolverFactory.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
- Coverage 64.82% 64.81% -0.01%
==========================================
Files 181 183 +2
Lines 6538 6554 +16
Branches 963 963
==========================================
+ Hits 4238 4248 +10
- Misses 2017 2020 +3
- Partials 283 286 +3 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
rkm
force-pushed
the
feature/path-resolvers
branch
from
October 10, 2024 13:04
a09e277
to
7f6d1ae
Compare
jas88
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
DefaultProjectPathResolver
has been renamed toStudySeriesOriginalFilenameProjectPathResolver
StudySeriesSOPProjectPathResolver
which generates filenames using SOPInstanceUID instead of the original file name. This is now the default path resolverTypes of changes
[skip ci]
Checklist
By opening this PR, I confirm that I have:
@SMI/Reviewers
teamIssues