#3090 removed hyperlinks and displaying co-occurring/uncertain in MVL export #906
Conversation
There was a problem hiding this comment.
So it's a very obscure edge case but:
Classifications can be put in the same group as long as the first resolved ontology term is shared
This means there could be a scenario where we have:
Condition A, Condition B, co-occurring
Condition A, Condition C, co-occurring
which would show up as
Condition A, Condition B, Condition C co-occurring.
To keep things safe, I'd suggest we only show the join term if the condition_resolution_obj for each condition is the same (not just if the joining term is the same).
| @@ -22,11 +23,16 @@ | |||
| <del>{{ group.clinical_significance | ekey:'clinical_significance' }}</del><br/>{{ group.clinical_significance_pending | ekey:'clinical_significance' }} (PENDING) | |||
| {% else %}{{ group.clinical_significance | ekey:'clinical_significance' }}{% endif %} | |||
| </td> | |||
| <td style='padding:8px'>{% for condition in group.conditions %}<div>{% condition condition_obj=condition limit=None %}</div>{% empty %}-{% endfor %}</td> | |||
| <td style='padding:8px'>{% for condition in group.conditions %}<div>{% condition condition_obj=condition limit=None no_links=True %}</div>{% empty %}-{% endfor %} | |||
There was a problem hiding this comment.
OntologyTerm has "show_link" which defaults to True, probably best to keep the convention (instead of "no_links" defaulting to False).
| @@ -371,19 +371,25 @@ def __lt__(self, other): | |||
| def conditions(self) -> List[ConditionResolved]: | |||
There was a problem hiding this comment.
(Note this is a left over from my code that made things more complicated than they need to be)
It might be cleanest to change the signature of ClassificationGroup.conditions to return a single ConditionResolved, as it only returns multiple now because a single ConditionResolved doesn't properly handle the merging of resolved terms and plain text - but they wont be grouped together anyway.
That way we don't need to hack the join term so much either (as in we can just use the condition tag as it was)
| {% endfor %} | ||
| {% if condition.join_text %} <span class="font-italic">{{ condition.join_text }}</span>{% endif %} |
There was a problem hiding this comment.
If we change ClassificationGroup as per the above suggestion, then we can put this back in.
Especially since {% condition %} is used in other contexts where we would want to show off the join text
No description provided.