-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClinVar Records Expert Panels / Allele UI tidy #862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- start integrating API for the data
# Conflicts: # classification/management/commands/imported_allele_info_check.py
Fix HP terms in disease list
Also note there's still work to be done on notifying users when the expert panels change after their classification submissions. This is the halfway step of getting the data, and being able to identify (via manual look or export) when the expert panels are newer. |
Still provide it for displaying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davmlaw this pull request covers both:
A redesign of the allele/variant data on the allele page.
Retrieving individual ClinVar records, showing Expert Panels on Allele pages, and updating to how ClinVar data is presented on the Variant Pages.
Which is a bigger chunk of work than what should be in a single PR, but it was all somewhat intertwined.
Happy to discuss the key points of during the dev meeteing.